Thank you Mike. I'm new to compiler but found some nice
Cyrill On Tue, Jan 8, 2013 at 2:05 AM, Michael Schmalle <apa...@teotigraphix.com> wrote: > BTW, I actually did look at your code awhile back and saw nothing wrong with > the grammar. > > As long as there is tests, it's good to go. > > Mike > > > Quoting Cyrill Zadra <cyrill.za...@gmail.com>: > >> Yes.. there are a few working unit tests. >> >> Cyrill >> >> On Sun, Dec 30, 2012 at 2:44 PM, Michael Schmalle >> <apa...@teotigraphix.com> wrote: >>> >>> I'll take a look at it in a day or so. If you got a unit test that works >>> I >>> would say you did a good job. :) >>> >>> Mike >>> >>> >>> Quoting "Cyrill Zadra (JIRA)" <j...@apache.org>: >>> >>>> >>>> [ >>>> >>>> https://issues.apache.org/jira/browse/FLEX-33275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541170#comment-13541170 >>>> ] >>>> >>>> Cyrill Zadra commented on FLEX-33275: >>>> ------------------------------------- >>>> >>>> Added support to declare a color with a rgb(x,x,x) definition. >>>> >>>> - I had to extend the CSS.g & CSSTree.g >>>> - Add a new antlr rule for - rgb(100%,100%,100%) - I'm new to antlr so >>>> probably someone has a shorter/better way to describe the RGB rule. >>>> - Add new class CSSRgbColorPropertyValue >>>> - Added Unit Test CSSRgbColorPropertyValueTests >>>> >>>> >>>> So it might be a compiler guru out there who can review this change ;-) >>>> .. gordon, mike?... thx. >>>> >>>>> Falcon Compile Error: Define a color with- rgb(100%, 0%, 0%) is not >>>>> supported. >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> >>>>> Key: FLEX-33275 >>>>> URL: https://issues.apache.org/jira/browse/FLEX-33275 >>>>> Project: Apache Flex >>>>> Issue Type: Improvement >>>>> Components: MXML Compiler >>>>> Reporter: Cyrill Zadra >>>>> Assignee: Cyrill Zadra >>>>> Labels: Falcon >>>>> Fix For: Apache Flex 4.9.0 >>>>> >>>>> Attachments: StyleRGB.mxml >>>>> >>>>> >>>>> Using rgb(100%, 0%, 0%) to define a color in a css return following >>>>> compiler error. >>>>> Compiler Error >>>>> [java] Error: >>>>> >>>>> C:/dev/apache-flex/falcon/compiler/src/org/apache/flex/compiler/internal/css/CSSTree.g: >>>>> node from line 0:0 no viable alternative at input 'rgb(100%, 0%, 0%)' >>>>> >>>> >>>> -- >>>> This message is automatically generated by JIRA. >>>> If you think it was sent incorrectly, please contact your JIRA >>>> administrators >>>> For more information on JIRA, see: >>>> http://www.atlassian.com/software/jira >>>> >>> >>> -- >>> Michael Schmalle - Teoti Graphix, LLC >>> http://www.teotigraphix.com >>> http://blog.teotigraphix.com >>> >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com >
