No worries, as long as we coordinate ;-) EdB
On Thu, Feb 14, 2013 at 12:13 PM, Michael Schmalle <apa...@teotigraphix.com> wrote: > Right, > > I agree with you, give my 30 minutes and I will have everything I have up to > this point committed with passing tests. > > My problem was, I shouldn't have committed anything last week(unit tests) > until I got to this point. My Bad. > > Mike > > > Quoting Erik de Bruin <e...@ixsoftware.nl>: > >> I wasn't suggesting you use the 'goog' tests, I was suggesting there >> is now room for an 'AMD' directory within 'test-files', in which you >> can put the AMD tests, and that you use the file based testing I added >> to TestBase.java (using 'getFileNode()' with a filename to feed the AS >> code to the compiler and 'getCodeFromFile()' to read the 'assert' code >> from a file). >> >> EdB >> >> >> >> On Thu, Feb 14, 2013 at 12:05 PM, Michael Schmalle >> <apa...@teotigraphix.com> wrote: >>> >>> >>> Quoting Erik de Bruin <e...@ixsoftware.nl>: >>> >>>> Mike, >>>> >>>> I was reading your commit notes and saw you're looking for a location >>>> to put your .as sources for testing. I've refactored the test-files >>>> location to allow for a AMD specific directory (did this yesterday, >>>> you should have the new directory layout) >>>> >>>> Also, I already have the testing of entire files (classes) in 'goog' >>>> and TestBase, you might want to look at "TestGoogFiles.java" and maybe >>>> bring that 'up' to the baseline tests and override for AMD and 'goog'? >>> >>> >>> >>> >>> Yeah I see where you are going with this BUT, at the moment I would >>> really >>> like to test the exact setup Frank has in his GIT repo. >>> >>> I figure for now I will put the .as files in the 'test-files' directory >>> IE >>> com/acme structure with ApacheLicenses. If in the future we find this is >>> unnecessary, the I will remove them. I will probably eventually use your >>> test classes as well but I don't want any Flash related classes like >>> EventDispatcher. >>> >>> >>> Mike >>> >>> >>> >>>> EdB >>>> >>>> >>>> >>>> -- >>>> Ix Multimedia Software >>>> >>>> Jan Luykenstraat 27 >>>> 3521 VB Utrecht >>>> >>>> T. 06-51952295 >>>> I. www.ixsoftware.nl >>>> >>> >>> -- >>> Michael Schmalle - Teoti Graphix, LLC >>> http://www.teotigraphix.com >>> http://blog.teotigraphix.com >>> >> >> >> >> -- >> Ix Multimedia Software >> >> Jan Luykenstraat 27 >> 3521 VB Utrecht >> >> T. 06-51952295 >> I. www.ixsoftware.nl >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
