On Sun, Mar 10, 2013 at 11:52 PM, Frédéric THOMAS
<webdoubl...@hotmail.com>wrote:
> Hi Om,
>
> Hum..., actualy, I've committed it already, what I did is I added to
> setXmlVariables a line :
>
> APACHE_FLEX_BIN_DISTRO_VERSION = fileName.substr(Constants.SDK_**
> BINARY_FILE_NAME_PREFIX.**length).split("-")[0];
>
> which I then used in the updateWindow function:
>
> this.nativeWindow.title = StringUtil.substitute(_**
> viewResourceConstants.INFO_**WINDOW_TITLE, [APACHE_FLEX_BIN_DISTRO_**
> VERSION]);
>
> Indeed I had to modify INFO_WINDOW_TITLE to make it accept a parameter.
>
> Still good for you ?
>
>
> -Fred
>
>
I still think it would be best if we did the sdk version detection logic in
the common library. If we start changing the way we name the SDK, we will
have only one place to modify. Our future selves would thank us for this
:-)
As for displaying the sdk version, could we display it in the same format
as the badge [1] in addition to the window title? That would make it look
more consistent. What do you think?
[1] http://flex.apache.org/installer
> -----Message d'origine----- From: Om
> Sent: Monday, March 11, 2013 7:37 AM
>
> To: dev@flex.apache.org
> Subject: Re: Apache Flex SDK Installer - 2.5 release?
>
> Fred,
>
> On Sun, Mar 10, 2013 at 9:34 AM, Frédéric THOMAS <webdoubl...@hotmail.com>
> wrote:
>
> I wonder as well how I update [1] to point 2.5 in the config file which
>> btw is named sdk-installer-config-2.0.xml, should it be renamed
>> sdk-installer-config-2.5.xml ?
>> I'm not sure I got all the logic there, could you explain pls.
>>
>>
>>
> Unless we are making structural changes to the config xml, there is no need
> for a sdk-installer-config-2.5.xml. The existing version should just work
> fine. It was designed this way intentionally.
>
>
>
>
> I would like to add the SDK version number that is going to be downloaded
>> somewhere, probably in the title, actually, the user doesn't know which
>> SDK
>> is going to download, what do you think ?
>>
>>
>> I wanted to add this functionality, but it would be great if you can get
> this done. The badge already does that in the parseSDKVersionNumber()
> method in /utilities/installerBadge/src/**InstallApacheFlexBadge.mxml. I
> think the best option would be to move this logic to the common library and
> use it from there.
>
>
>
> -Fred
>>
>> [1] <file name="SDKInstallerApp"
>> path="https://dist.apache.org/****<https://dist.apache.org/**>
>> repos/dist/dev/flex/installer/****2.0/rc1/binaries/<https://**
>> dist.apache.org/repos/dist/**dev/flex/installer/2.0/rc1/**binaries/<https://dist.apache.org/repos/dist/dev/flex/installer/2.0/rc1/binaries/>
>> >"
>> file="apache-flex-sdk-****installer-2.0.3-bin" />
>>
>>
>> The path can be an absolute path that should start with "http" or a
> relative path in which case the mirror url with this relative path would be
> used. We typically use the absolute path to test Release Candidates of the
> Flex SDK. And the relative paths for actual release to be downloaded from
> the mirror site.
>
>
>
>> Ok, forget my 2nd question, I haven't see that "You need to obtain the
>> installapacheflex_self.p12 file and its password from the previous release
>> manager for InstallApacheFlex".
>> So, who was the last release manager, You ?
>>
>>
>> Yes, I was. I will send you the certificate and the password files in
> separate emails to you.
>
>
> On Sun, Mar 10, 2013 at 4:47 PM, Frédéric THOMAS <webdoubl...@hotmail.com>
> **wrote:
>
> Hi Om, I'm waiting for your answers, comments...
>>
>> I just committed that:
>> - added INFO_TRACKING for French
>> - copied the English version of INFO_TRACKING for Spanish and Greek and
>> splitted them to make it fit between both the buttons.
>> - Added the SDK version number in the title of the native window.
>> - Updated the Installer Version Number to 2.5
>>
>> It's late and I go to sleep now, btw, it's not "French and German language
>> locale fixes." but more "French and Dutch language locale fixes." as we
>> don't have German as locale in the Installer, I will update the release
>> note accordingly tomorrow.
>>
>>
>> Sounds fantastic! Thanks for taking this up. Since, this is your first
> release, you may need to set up your public keys, etc. Please let me know
> how I can help.
>
> Thanks,
> Om
>
