Okay. But I'll have to set up another machine to run Mustella on, and I'll probably need some hand-holding on it…
On Apr 7, 2013, at 12:53 PM, Frédéric THOMAS wrote: > And sorry again but now you are committer, I guess it is your duty to run the > Mustella tests to ensure the fix doesn't break them (or eventually you'll > need to adapt the tests too). > > -Fred > > -----Message d'origine----- From: Frédéric THOMAS > Sent: Sunday, April 07, 2013 11:46 AM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > And maybe it can be fixed directly in the Sinner at override public function > changeValueByStep(increase:Boolean = true):void > > -Fred > > -----Message d'origine----- From: Frédéric THOMAS > Sent: Sunday, April 07, 2013 11:43 AM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > Hi Harbs, > > I guess you will have the opportunity to do it again. > > What if 0 is out of the Range ? > > I guess the right fix is: > > if(isNaN(newValue)) > newValue = minimum; > > -Fred > > -----Message d'origine----- From: Harbs > Sent: Sunday, April 07, 2013 11:38 AM > To: dev@flex.apache.org > Subject: Re: git commit: Added override to set value to ensure it is not set > to NaN > > I thought it was automatically prepended because I created a branch for it. > I see that when I deleted the branch, the JIRA number disappeared. Still > learning git… ;-) > > FWIW, it was FLEX-33288 > > Harbs > > On Apr 7, 2013, at 11:57 AM, Frédéric THOMAS wrote: > >> Take the habit to prepend the issue id to your commit message, it is useful >> if someone wants to see the modified code from the source tab of the Jira >> issue. >> >> -Fred >> >> -----Message d'origine----- From: ha...@apache.org >> Sent: Sunday, April 07, 2013 9:02 AM >> To: comm...@flex.apache.org >> Subject: git commit: Added override to set value to ensure it is not set to >> NaN >> >> Updated Branches: >> refs/heads/develop 9ec4d1780 -> 53ad8aa03 >> >> >> Added override to set value to ensure it is not set to NaN >> >> >> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo >> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/53ad8aa0 >> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/53ad8aa0 >> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/53ad8aa0 >> >> Branch: refs/heads/develop >> Commit: 53ad8aa037d29e1055ec6b532513fa50df730c81 >> Parents: 9ec4d17 >> Author: Harbs <ha...@in-tools.com> >> Authored: Sun Apr 7 09:58:20 2013 +0300 >> Committer: Harbs <ha...@in-tools.com> >> Committed: Sun Apr 7 09:58:20 2013 +0300 >> >> ---------------------------------------------------------------------- >> .../spark/src/spark/components/NumericStepper.as | 11 +++++++++++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/53ad8aa0/frameworks/projects/spark/src/spark/components/NumericStepper.as >> ---------------------------------------------------------------------- >> diff --git >> a/frameworks/projects/spark/src/spark/components/NumericStepper.as >> b/frameworks/projects/spark/src/spark/components/NumericStepper.as >> index 36a1982..0848245 100644 >> --- a/frameworks/projects/spark/src/spark/components/NumericStepper.as >> +++ b/frameworks/projects/spark/src/spark/components/NumericStepper.as >> @@ -740,6 +740,17 @@ public class NumericStepper extends Spinner >> /** >> * @private >> */ >> + override public function set value(newValue:Number):void >> + { >> + if(isNaN(newValue)) >> + newValue = 0; >> + >> + super.value = newValue; >> + } >> + >> + /** >> + * @private >> + */ >> override protected function setValue(newValue:Number):void >> { >> super.setValue(newValue); >> >
