Please open a JIRA issue with your patch.
On 4/10/13 6:40 AM, "Tigran Najaryan" <[email protected]> wrote: >> org.apache.flex.compiler.internal.codegen.mxml.flexjs.MXMLFlexJSEmitter >> .java >> is a good place to start :-) > > OK, I did some very simple refactoring. Let me know if it makes any sense. > > I verified that the refactored code emits exactly the same output when > compiling the FlexJSTest_again sample. > > Patch file attached (as output by git diff -- MXMLFlexJSEmitter.java, is > this the correct way to create a patch file?). > > Comments and criticism are welcome. > > > One question. > > The old code was emitting an indentation based on a condition (!isMainFile > || propertySpecifierNodes == null) however there was no matching indentPop() > for the earlier indentPush() call. Can you please explain what does this do? > I probably do not understand it but it looks like some kind of incomplete > code to me. > > My refactored version is currently functionally equivalent to the old code, > it passes an 'indent' parameter to emitClassDeclStart(). > > Tigran. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
