Understood. I'm asking these questions to find out what you had time to really think about and what was done quickly.
I'll leave goog.array.foreach for now unless it causes other problems. On 4/10/13 11:48 PM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > I don't think I changed what is output for anything that I wrote > specifically for FlexJS, however, 'the rest' of the AS parsing code is > the code I wrote for 'goog' JS, and there are some experiments in > there. Specifically to 'foreach': I threw that in because "it was > there" and there was lots of other things that didn't have readily > available (partial) solutions. So don't be surprised if you find stuff > like that lying around. Also, if there is a better/faster/more > convenient solution available, feel free to use that. Again, in my > limited time (I do have a day job), I do what I can, but it won't > always be 'production ready' per se, and it will hardly ever be > 'enterprise ready'. This is why I love to have more eyes (and hands) > on the FalconJX code, the project will benefit from it. > > EdB > > > > On Thu, Apr 11, 2013 at 8:13 AM, Alex Harui <aha...@adobe.com> wrote: >> >> >> >> On 4/10/13 10:47 PM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: >> >>> Once we've migrated >>> to FalconJX and have some proper functional tests in place, we can >>> start to change the output, correct? >>> >> Yup, although I'm seeing that you've already changed some of it. I'm >> working on the fact that goog.array.foreach can't handle break statements. >> I'm not clear why we chose goog.array.foreach instead of goog.iter.foreach, >> or even just replacing it with for..in like FalconJS does, which does handle >> break statements. >> >> -- >> Alex Harui >> Flex SDK Team >> Adobe Systems, Inc. >> http://blogs.adobe.com/aharui >> > > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
