I can't fix what I can't debug ;-) Maybe spend a little time to abstract the pain points from that project into a "TestGoogProject" style test project, so we can all work on them? As an added bonus, by having (a) test(s) we'd prevent regressions like this one in future updates...
EdB On Sat, Apr 20, 2013 at 4:43 PM, Alex Harui <[email protected]> wrote: > Yup. > > > On 4/20/13 7:29 AM, "Erik de Bruin" <[email protected]> wrote: > >> Yesterday all was well in dependency-land... was it your "customer's >> project" that caused you to tweak the algoritm? >> >> EdB >> >> >> >> On Sat, Apr 20, 2013 at 3:02 PM, Alex Harui <[email protected]> wrote: >>> >>> >>> >>> On 4/20/13 3:40 AM, "Erik de Bruin" <[email protected]> wrote: >>> >>>> Alex, >>>> >>>> Somewhere in your last commit(s) something broke. I'm now getting this >>>> error when I run a cleanly build MXMLJSC with a cleanly build >>>> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example: >>>> >>>> ERROR - Circular dependency detected: controllers.MyController -> >>>> controllers.MyController >>>> >>>> The tests do pass and the debug output works fine, so I'm guessing >>>> it's the Closure Compiler that is reporting this error. >>>> >>>> FYI: when I cut a branch from before your commits >>>> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler, >>>> all is well. And cutting a branch before Gordon's commits shows it's >>>> not him, I'm afraid. >>>> >>>> Any ideas? >>>> >>> I'll look into it. This, IMO, is a major flaw in Closure. I can't tell you >>> how many times I've tweaked this algorithm and how many hours we've wasted. >>> >>> -- >>> Alex Harui >>> Flex SDK Team >>> Adobe Systems, Inc. >>> http://blogs.adobe.com/aharui >>> >> >> > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
