On 6/12/13 9:50 AM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> IMO, it is risky to leave the ADG's renderers in this state. >Fair enough and I'm sure you know more about the ADG innards than me. > >> But the question is, what about some third-party who extended the >>renderer and added another style >> not in this list? >They could override the setStyle method? > >The fix in question I had in several ADGs in production for several years >and not run into any issues (including navigation key support), but they >are not using any RTL ADGs. Yeah, and it turns out that most styles you set cause a full recalc of the renderers which is why you probably haven't seen any side-effects. So we're definitely not talking about the majority case, but I generally prefer fixing the root problem instead of just the symptoms. > >> 3) Changing this styleProp "if" to a lookup on some mx_internal > >> object/map. Rating: -0.1. Again this leaves the flag set to true, but >>at >> least gives someone a way to hack in other properties (plus the check >>will >> be much faster). >Don't think speed is a huge issue here when changing layoutDirection. How >often would you change the layoutDirection in a real application? It isn't about layoutDirection, any style property change comes through styleChanged and that long list of styleProps to check. If you switch to a hashmap it will go faster and someone could add other properties if they get trapped by this scenario. > >I have a look at the options in more detail once I get some time - likely >to be end of the week/next week. OK, good luck. -Alex
