On Sep 26, 2013 9:34 PM, "Alex Harui" <aha...@adobe.com> wrote:
>
> Hi Maurice,
>
> I imported the two files into FB and I ran the Apache file scanner on the
> folders. Looks good. Here are some things I saw:
>
> 1) If you plan to check in the FB project properties like
> .actionScriptProperties, you will need to insert headers in them as well.
> 2) Are you planning to check in the sample somewhere? If so, the
> following files also need headers:
> MobileDataGridSample/src/MobileDataGridSample-app.xml
> MobileDataGridSample/src/utils/FPSDisplay.as
The flex-examples repo would be the place for these samples.
Thanks,
Om
> 3) Just want to make sure that the .png files are owned by Systar. If
> they were created by a third-party, then you may need to verify the
> agreement with the provider allows donation.
>
>
> When you check in, the NOTICE and LICENSE files don't get checked in and
> the portion of the NOTICE file regarding Systar goes in the top-level
> NOTICE file, where instead of saying "Original Code" you might want to use
> "com.systar.fx.mobile.components.MobileDataGrid" or whatever you rename it
> to.
>
> After check-in, please carve out some time for ASDoc and other comments.
> I'd also like to see you switch to the {} style used in most of the rest
> of the framework and fix up some whitespace indentation issues if you have
> time.
>
> Other than that, I think we're all set. Did you specify an Apache account
> name on your ICLA? I don't get to see them and I'll need it to finish
> giving you write-access. It may take the weekend to finish up the
> write-access process. We'll let you know when your account is ready.
>
> Thanks again for the donation,
> -Alex
>
> On 9/26/13 11:59 AM, "Alex Harui" <aha...@adobe.com> wrote:
>
> >Hi Maurice,
> >
> >Thanks! I will review it this evening.
> >
> >-Alex
> >
> >On 9/26/13 11:46 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
> >wrote:
> >
> >>Hi,
> >>
> >>I have added the headers, LICENSE and NOTICE and attached the source
code
> >>attached to the JIRA ticket :
> >>https://issues.apache.org/jira/browse/FLEX-33777
> >>
> >>Regards,
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
> >>Envoyé : jeudi 26 septembre 2013 19:55
> >>À : dev@flex.apache.org
> >>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>Applications
> >>
> >>Thanks for the clarification.
> >>
> >>I won't put the @author tag then.
> >>
> >>Maurice
> >>
> >>-----Message d'origine-----
> >>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 26 septembre
> >>2013 19:45 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>donation of Systar DataGrid for Mobile Applications
> >>
> >>Hi Maurice,
> >>
> >>Most projects at Apache discourage author tags. There is no official
> >>policy prohibiting and Apache Flex has not made any decision.
> >>
> >>The general reasoning is that there are currently 40+ committers and
> >>growing on Apache Flex and if everyone who touched a file added an
author
> >>tag, eventually, some classes would eventually have a long list of tags.
> >>Source-control history will always record you as the author, so I'd
leave
> >>it out if you're ok with that, but either way, it won't affect the
> >>donation.
> >>
> >>-Alex
> >>
> >>
> >>On 9/26/13 10:37 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
> >>wrote:
> >>
> >>>I am adding the headers now.
> >>>
> >>>I noticed some of the components in experimental had mention of the
> >>>original author, in addition to Apache Header. (see below).
> >>>Should I do the same ?
> >>>Eg. @author Maurice Amsellem for SYSTAR (maurice.amsel...@systar.com).
> >>>
> >>>
> >>>Spark/components/itemRenderers/MenuItemRenderer.mxml
> >>>
> >>>
> >>>///////////////////////////////////////////////////////////////////////
> >>>//
> >>>///////
> >>> //
> >>> // Licensed to the Apache Software Foundation (ASF) under one or
more
> >>> // contributor license agreements. See the NOTICE file
distributed
> >>>with
> >>> // this work for additional information regarding copyright
ownership.
> >>> // The ASF licenses this file to You under the Apache License,
> >>>Version
> >>>2.0
> >>> // (the "License"); you may not use this file except in
compliance
> >>>with
> >>> // the License. You may obtain a copy of the License at
> >>> //
> >>> // http://www.apache.org/licenses/LICENSE-2.0
> >>> //
> >>> // Unless required by applicable law or agreed to in writing,
software
> >>> // distributed under the License is distributed on an "AS IS"
BASIS,
> >>> // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or
> >>>implied.
> >>> // See the License for the specific language governing
permissions and
> >>> // limitations under the License.
> >>> //
> >>>
> >>>///////////////////////////////////////////////////////////////////////
> >>>//
> >>>///////
> >>> @author Bogdan Dinu (http://www.badu.ro)
> >>> -->
> >>>
> >>>-----Message d'origine-----
> >>>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
> >>>Envoyé : jeudi 26 septembre 2013 19:02
> >>>À : dev@flex.apache.org
> >>>Objet : RE: [VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>Applications
> >>>
> >>>OK, I will add the Apache headers and Notice, and send you the code,
> >>>tonight or tomorrow latest...
> >>>
> >>>Maurice
> >>>
> >>>-----Message d'origine-----
> >>>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 26 septembre
> >>>2013 18:43 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>donation of Systar DataGrid for Mobile Applications
> >>>
> >>>In theory, Systar's legal department should be requiring some form of
> >>>header on any code leaving your company. So yes, adding headers is
> >>>advised and it would be my preference and probably save time in the end
> >>>if you use the Apache headers and NOTICE file.
> >>>
> >>>IMO, no other changes to the code are required at this time. In fact,
> >>>other than the headers, the code should be the same that your officers
> >>>signed for in the grant ;-).
> >>>
> >>>Thanks again for the donation,
> >>>-Alex
> >>>
> >>>On 9/26/13 9:34 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
> >>>wrote:
> >>>
> >>>>We also received the acknowledgments. That's good news.
> >>>>
> >>>>Do I need to make the changes requested before (Apache headers, etc..)
> >>>>before sending you the sources ?
> >>>>
> >>>>Maurice
> >>>>
> >>>>-----Message d'origine-----
> >>>>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 26 septembre
> >>>>2013 18:31 À : dev@flex.apache.org Objet : Re: [VOTE][LAZY] Accept
> >>>>donation of Systar DataGrid for Mobile Applications
> >>>>
> >>>>Hi Maurice,
> >>>>
> >>>>The grant was filed today. Please make a snapshot of the code
> >>>>available when you can. You can email the link or source to me
> >>>>directly. Any other PMC'rs want to help with the IP review?
> >>>>
> >>>>-Alex
> >>>>
> >>>>On 9/25/13 7:56 PM, "Alex Harui" <aha...@adobe.com> wrote:
> >>>>
> >>>>>Again, none of this is required pre-donation. But if you have the
> >>>>>time, that would be great.
> >>>>>
> >>>>>On 9/25/13 5:32 PM, "Maurice Amsellem" <maurice.amsel...@systar.com>
> >>>>>wrote:
> >>>>>
> >>>>>>OK.
> >>>>>>
> >>>>>>-----Message d'origine-----
> >>>>>>De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : jeudi
> >>>>>>26 septembre 2013 02:24 À : dev@flex.apache.org Objet : Re:
> >>>>>>[VOTE][LAZY] Accept donation of Systar DataGrid for Mobile
> >>>>>>Applications
> >>>>>>
> >>>>>>Hi,
> >>>>>>
> >>>>>>> 2) 240 and 480 DPI assets are missing. I will add them.
> >>>>>>You might need to add 120 and 640 as well as those have been
> >>>>>>recently added to the SDK.
> >>>>>>
> >>>>>>Thanks,
> >>>>>>Justin
> >>>>>
> >>>>
> >>>
> >>
> >
>
