Hi, I have pushed Callout and CalloutButton to develop. For me, it's ok . Can someone review the code ?
BTW, I have enabled the dormant "borderThickness" and "borderColor" code in CalloutSkin, by adding them as new Styles to Callout. By default, the desktop Callout skin now has a 1pix black border, and a light gray gradient 6 pix "frame", so that it looks more like other spark components. Mobile skin didn't change. Updated the DP demo so that you can check what it looks like: https://dl.dropboxusercontent.com/u/12169005/ApacheFlex/DesktopCalloutDemo.swf Testing: Did some manual and mustella tests before the commit: - Manual tests: - run sample Mobile app, with Navigation, Tabs, buttons, List, and Callout => all looking good. - Mustella mini_runs: Mobile/Components/Button => OK Mobile/Components/CalloutButton => didn't run .. Maurice -----Message d'origine----- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : lundi 7 octobre 2013 19:21 À : dev@flex.apache.org Objet : RE: Issue with CallOut ASDOC Sure. I will do that. Maurice -----Message d'origine----- De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de OmPrakash Muppirala Envoyé : lundi 7 octobre 2013 19:19 À : dev@flex.apache.org Objet : Re: Issue with CallOut ASDOC On Mon, Oct 7, 2013 at 9:06 AM, Maurice Amsellem < maurice.amsel...@systar.com> wrote: > Hi Team, > This is the approach I took to integrate Callout to spark: > - pushed s:Callout and related classes from mobilecomponents to spark > - copied the mobile skins to spark > - create a new base class that monkey patch MobileSkin in spark ( > could serve for other components as well) > - changed the default css colors and settings. > > Sounds good to me. Did you also try a mobile app (in various dpis) to make sure we can still use that without any changes to existing code? That would be crucial. > Here is a simple demo app that shows the result. > > > https://dl.dropboxusercontent.com/u/12169005/ApacheFlex/DesktopCallout > Demo.swf > Looks awesome! One nitpick: The 'close' button does not seem to close the callout. The 'OK' button seems to be working fine though. Not sure if this is a bug in the component or in the wrapper code. > > Note: I tried with a lighter background, but it does not look well, > because it's missing an 1 pixel dark outline. > I like the current way you have done it. +1 from my side to keep it this way. > Note2: does applicationDPI make sense also on desktop apps (maybe with > Macbook retina displays) ? > I dont think so. No other components use applicationDPI for desktop/web. This maybe one reason why we want to maintain separate skins for desktop/web and mobile. Thanks, Om > > You feedback is welcome. > > Maurice > > -----Message d'origine----- > De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] > Envoyé : dimanche 6 octobre 2013 21:27 À : dev@flex.apache.org Objet : > RE: Issue with CallOut ASDOC > > Thanks for the info > > -----Message d'origine----- > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > OmPrakash Muppirala Envoyé : dimanche 6 octobre 2013 21:13 À : > dev@flex.apache.orgObjet : Re: Issue with CallOut ASDOC > > On Sun, Oct 6, 2013 at 12:03 PM, Maurice Amsellem < > maurice.amsel...@systar.com> wrote: > > > >In fact, I like the mobile skin. Perhaps we can use the same skin > > >for > > desktop as well? We may want to lighten the default background > > color to match that of the default >Flex spark skins, though. > > > > Totally agree. The desktop skin is very dull in comparison. So a > > lighter mobile skin would be perfect for Desktop. > > > > So I will first try to merge the two host components in one, and > > then "PC-ize" the mobile skin. > > > > Do you know if any problems aroused when working on the experimental > > callout, so that I can avoid them (ie, benefit from previous > > experience) > ? > > > > > The experimental Callout components were created by Marcus Fritze and > Maxime Cowez. There are more details in this JIRA ticket: > https://issues.apache.org/jira/browse/FLEX-33350 > > Hope that helps. > > Thanks, > Om > > > > Regards, > > > > Maurice > > > > -----Message d'origine----- > > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > > OmPrakash Muppirala Envoyé : dimanche 6 octobre 2013 20:55 À : > > dev@flex.apache.org Objet : Re: Issue with CallOut ASDOC > > > > On Sun, Oct 6, 2013 at 11:11 AM, Maurice Amsellem < > > maurice.amsel...@systar.com> wrote: > > > > > Hi Team, > > > > > > Actually, after looking at the experimental CallOut code, it's > > > 95% similar to the original Callout. > > > > > > I don't know the story from the beginning, but I think it has been > > > monkey-patched because the properties "actualHorizontalPosition" > > > and "actualVerticalPosition" were protected, to make them > > > accessible (mx_internal). > > > > > > So now that I know how to change and recompile the SDK :-), > > > > > > I just made that simple change (ie protected => mx_internal) in > > > the original Callout class, and I can know use it in desktop (ie > > > the callout pops up) > > > > > > Of course, I used a dumb Skin, to it does not look like a callout > > > at all, but it should be feasible to adapt the experimental > > > CallOutSkin to make it work on the original class. > > > And it probably needs some more testing to make sure it works fine. > > > > > > So maybe we don't even need two classes, after all. > > > > > > After all, all other spark components (List, Panel, etc..) have > > > the same hostComponent , and only differ by their skin on mobile > > > and desktop platforms. > > > > > > What do you think? > > > > > > > I remember that there was a discussion about this a while ago. > > Unsure as to why we decided on a new component. > > But I agree with you that we should merge these two components into one. > > > > In fact, I like the mobile skin. Perhaps we can use the same skin > > for desktop as well? We may want to lighten the default background > > color to match that of the default Flex spark skins, though. > > > > Thanks, > > Om > > > > > > > > > > Maurice > > > > > > -----Message d'origine----- > > > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > > > OmPrakash Muppirala Envoyé : dimanche 6 octobre 2013 18:54 À : > > > dev@flex.apache.org Objet : Re: Issue with CallOut ASDOC > > > > > > On Oct 6, 2013 9:13 AM, "Maurice Amsellem" > > > <maurice.amsel...@systar.com> > > > wrote: > > > > > > > > Hi Team, > > > > > > > > I have noticed some classes asdoc link is broken on > > > flex.apache.org/asdoc > > > > > > > > https://issues.apache.org/jira/browse/FLEX-33802 > > > > > > > > I propose an explanation and two possible fixes , but not sure > > > > what to > > > do, because I don't know how the release builds are done and deployed. > > > > > > > > Can you please confirm/contradict the proposed explanation and > > > > which fix > > > should be implemented. > > > > > > +1 for renaming the fault class names. > > > > > > Thanks for catching this! > > > > > > Om > > > > > > > > > > > Regards, > > > > > > > > Maurice Amsellem > > > > SYSTAR R&D - BusinessBridgeFX > > > > > > > > > >
