Thanks a lot Alex, the fix worked perfectly I will make the same changes on
ComboBox class as well
Just one thing that I had to make on the top of your commit, you used the
ArraySelectionModel but didn't added a
goog.require('org.apache.flex.html.staticControls.beads.models.ArraySelectionModel'),
depending on other components that use this class you may or may not run into
this issue, things like these are the whole point on FlexJS advantage anyway :D
Thanks,
Pratyoosh
-----Original Message-----
From: Alex Harui [mailto:[email protected]]
Sent: Saturday, October 12, 2013 1:13 AM
To: [email protected]
Subject: RE: [FlexJS] FLEX-33778 Combobox & DropdownList ListBase.js throws a
NPE
I discovered today that DropDownList.js was broken. I made some quick changes
to it to get it to work for the DataBindingTest demo. We'll take a harder look
at it next week. I think things got a bit mixed up as Peter was trying out the
itemrenderer capability.
Thanks for trying FlexJS,
-Alex
________________________________________
From: Sharma, Pratyoosh [[email protected]]
Sent: Friday, October 11, 2013 1:57 PM
To: [email protected]
Subject: RE: [FlexJS] FLEX-33778 Combobox & DropdownList ListBase.js throws a
NPE
Started to look at FlexJS again, so let me try to understand what was intention
of implementation ListBase should define the model & comboBox etc should set
the dataprovider on the model of their superclass
Is this what was intended but ListBase never added the model bead for whatever
reason
Thanks,
Pratyoosh
-----Original Message-----
From: Peter Ent [mailto:[email protected]]
Sent: Wednesday, September 25, 2013 2:08 PM
To: [email protected]
Subject: Re: [FlexJS] FLEX-33778 Combobox & DropdownList ListBase.js throws a
NPE
I'm taking a look now. I did make some changes to the list code recently, so
maybe I hit this already.
--peter
On 9/25/13 12:17 PM, "Alex Harui" <[email protected]> wrote:
>Hi Pratyoosh,
>
>One of us will take a look. In theory the model gets assigned early in
>the lifecycle (and pulled from the CSS iBeadModel style. Maybe you've
>found a way to run code before that happens?
>
>-Alex
>
>On 9/25/13 9:03 AM, "Sharma, Pratyoosh" <[email protected]>
>wrote:
>
>>It seems like It seems like ListBase.js throws a Null pointer
>>exception since the model is never initialized for Dropdown & ComboBox
>>classes on FlexJS.
>>Not sure why the examples work since the latest code doesn't seems to
>>have anything that initializes the model bead for these components
>>
>>Cross referenced by https://issues.apache.org/jira/browse/FLEX-33778
>>
>>Thanks,
>>Pratyoosh
>>
>>
>>This email is confidential and subject to important disclaimers and
>>conditions including on offers for the purchase or sale of securities,
>>accuracy and completeness of information, viruses, confidentiality,
>>legal privilege, and legal entity disclaimers, available at
>>http://www.jpmorgan.com/pages/disclosures/email.
>
This email is confidential and subject to important disclaimers and conditions
including on offers for the purchase or sale of securities, accuracy and
completeness of information, viruses, confidentiality, legal privilege, and
legal entity disclaimers, available at
http://www.jpmorgan.com/pages/disclosures/email.
This email is confidential and subject to important disclaimers and conditions
including on offers for the purchase or sale of securities, accuracy and
completeness of information, viruses, confidentiality, legal privilege, and
legal entity disclaimers, available at
http://www.jpmorgan.com/pages/disclosures/email.
