I have tried again the initial fix for FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed ) that consisted in adding a missing "validateNow()" before setting verticalPosition=0 (line 5449)
It's not optimal, because of the validateNow(), BUT Mustella tests are passing. ----- The other FIX for this same issue, that Alex helped me write, uses a deferred processing in updateDisplayList() Using changed flags and invalidateList(). It's optimal for performance BUT it breaks 3 mustella tests, but is good too. ------- Intuitively, I would say that both fixes are OK, but the latter one has side effects because of the deferred behavior. So should I commit the initial fix, although it's not optimal? ----------- Note: as I said before, validateNow() is used in all other similar processing in Grid / DataGrid. So it may be non optimal, but it's not less optimal than the existing code. Maurice -----Message d'origine----- De : Justin Mclean [mailto:[email protected]] Envoyé : mardi 15 octobre 2013 00:18 À : [email protected] Objet : Re: Build failed in Jenkins: flex-sdk_mustella #470 Hi, > Do I commit/push to develop as usual, and let Justin merge with release , or > commit directly to release ? It's a bit of a mess - but as you reverted in develop I'd un revert/recommit the changes in develop. Thanks, Justin
