OK, thanks for staying with it. In looking at the code, it occurred to me that before the change, resetDP has a bunch of addItem calls which would call the caretChangeHandler often. Maybe that isn't happening in the deferred version and thus the ensureIndexIsVisible isn't being called for the first item? Or something like that?
-Alex On 10/14/13 5:20 PM, "Maurice Amsellem" <[email protected]> wrote: >To be more acurate, when the test initially fails, the bitmap shows the >list is scrolled to the end, >whereas the baseline bitmaps has it scrolled to the top, with the first >cell selected. >Which means it does not scroll to the top. > >The fact that updateComplete is not triggered either, would suggest the >UDL is not called ??? > >I need to debug to find out, but too late for today (already 2:20 am in >Paris). > >Maurice > >-----Message d'origine----- >De : Maurice Amsellem [mailto:[email protected]] >Envoyé : mardi 15 octobre 2013 02:10 >À : [email protected] >Objet : RE: Build failed in Jenkins: flex-sdk_mustella #470 > >I changed to following: ><RunCode code="FlexGlobals.topLevelApplication.dataGrid.resetDP()" >waitEvent="updateComplete" waitTarget="dataGrid" /> > >Instead of : > <RunCode code="FlexGlobals.topLevelApplication.dataGrid.resetDP()" >waitEvent="enterFrame" waitTarget="stage"/> > >DataGrid_comp3.resetDP() is actually re-assigning the dataProvider, so >this SHOULD eventually trigger an updateComplete event. > >Unfortunately, the test fails with : > >Failed RunCode(body:step 3) Timeout waiting for updateComplete from >dataGrid > >Any idea ? > >Maurice > >-----Message d'origine----- >De : Maurice Amsellem [mailto:[email protected]] >Envoyé : mardi 15 octobre 2013 02:00 >À : [email protected] >Objet : RE: Build failed in Jenkins: flex-sdk_mustella #470 > >>Worth trying. But can you set a breakpoint on updateDisplayList to make >>sure it doesn't get called twice? We want to make sure the deferred >>work doesn't force another round >of validation. > >I remember I did that already when manually testing the fix: I did >several changes to the dataProvider, but only one UDL was executed. > >Maurice > >-----Message d'origine----- >De : Alex Harui [mailto:[email protected]] Envoyé : mardi 15 octobre 2013 >01:55 À : [email protected] Objet : Re: Build failed in Jenkins: >flex-sdk_mustella #470 > >Worth trying. But can you set a breakpoint on updateDisplayList to make >sure it doesn't get called twice? We want to make sure the deferred work >doesn't force another round of validation. > >-Alex > >On 10/14/13 4:50 PM, "Maurice Amsellem" <[email protected]> >wrote: > >>>Sounds like a timing issue with the tests. eg They need to wait for >>>undateComplete event? >> >>In the test case below (which was one of the failing), after the DP has >>been reset, it's waiting for the next frame: >> >><RunCode code="FlexGlobals.topLevelApplication.dataGrid.resetDP()" >>waitEvent="enterFrame" waitTarget="stage"/> >> >>And after that, it's waiting for two more frames before comparing the >>bitmaps... >><WaitForEvent target="stage" eventName="enterFrame" >>numExpectedEvents="2"/> >> >>So maybe I should change to waitEvent="updateComplete" so that it wait >>until the udateDisplayList ? >> >> >> >> >> <TestCase testID="requireSelection_test15" >>keywords="[GridSelection,property,requireSelection ]" >> description="Test selection is on first row/cell,reset >>dataprovider,verify first row/cell is still selected"> >> <setup> >> <ResetComponent target="dataGrid" >>className="components.DataGrid_comp3" waitEvent="updateComplete" /> >> <WaitForEvent target="stage" eventName="enterFrame" >>numExpectedEvents="2"/></setup> >> <body> >> <RunCode >>code="FlexGlobals.topLevelApplication.dataGrid.selectionMode=GridSelect >>ion >>Mode.MULTIPLE_CELLS"/> >> <AssertMethodValue >>method="value=FlexGlobals.topLevelApplication.dataGrid.selectionContain >>sCe >>ll(0,0)" value="true"/> >> <RunCode >> code="FlexGlobals.topLevelApplication.dataGrid.resetDP()" >>waitEvent="enterFrame" waitTarget="stage"/> >> <AssertMethodValue >>method="value=FlexGlobals.topLevelApplication.dataGrid.selectionContain >>sCe >>ll(0,0)" value="true"/> >> <WaitForEvent target="stage" eventName="enterFrame" >>numExpectedEvents="2"/> >> <CompareBitmap numColorVariances="20" >> maxColorVariance="20" >>url="../Properties/Baselines/$testID_cell.png" target="dataGrid"/> >> </body> >> </TestCase> >> >> >>Maurice >> >>-----Message d'origine----- >>De : Justin Mclean [mailto:[email protected]] Envoyé : mardi 15 >>octobre 2013 01:34 À : [email protected] Objet : Re: Build failed in >>Jenkins: flex-sdk_mustella #470 >> >>HI, >> >>Sounds like a timing issue with the tests. eg They need to wait for >>undateComplete event? >> >>Justin >
