At this point in the development of the framework, no. Premature optimization and all that… I'd maybe mark it as a TODO.
Remember, there is a second compiler (Closure) in the tool chain which takes care of most of the 'bloat' when it is creating release code. All those interfaces and nested classes go away, as they contain no actual, executable code pathways. EdB On Friday, November 8, 2013, Alex Harui wrote: > I'm good with that, but what if the original implementation was > significantly faster on JS but not on AS? Would you then allow for a > different implementation? > > On 11/7/13 11:27 AM, "erikdebr...@apache.org <javascript:;>" < > erikdebr...@apache.org <javascript:;>> > wrote: > > >Updated Branches: > > refs/heads/develop 4b17f61ce -> 9fa2c6f9b > > > > > >An example of how API parity would look. I started at SimpleStateImpl and > >worked my way up ;-) > > > >Also, all these files now comply with the gjslint and JSHint code quality > >requirements. > > > >Signed-off-by: Erik de Bruin <e...@ixsoftware.nl> > > > > > >Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > >Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/9fa2c6f9 > >Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/9fa2c6f9 > >Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/9fa2c6f9 > > > >Branch: refs/heads/develop > >Commit: 9fa2c6f9ba48b7404a873a26ca98658f1aa33e2d > >Parents: 4b17f61 > >Author: Erik de Bruin <e...@ixsoftware.nl> > >Authored: Thu Nov 7 20:27:13 2013 +0100 > >Committer: Erik de Bruin <e...@ixsoftware.nl> > >Committed: Thu Nov 7 20:27:21 2013 +0100 > > > >---------------------------------------------------------------------- > > frameworks/js/FlexJS/src/mx/states/AddItems.js | 35 +++- > > .../js/FlexJS/src/mx/states/SetProperty.js | 35 +++- > > frameworks/js/FlexJS/src/mx/states/State.js | 4 +- > > .../src/org/apache/flex/core/IStatesImpl.js | 38 +++++ > > .../FlexJS/src/org/apache/flex/core/IStrand.js | 55 ++++++ > > .../org/apache/flex/core/SimpleStatesImpl.js | 171 ++++++++++--------- > > .../org/apache/flex/events/IEventDispatcher.js | 25 +++ > > 7 files changed, 272 insertions(+), 91 deletions(-) > >---------------------------------------------------------------------- > > > > > > > http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9fa2c6f9/frameworks/ > >js/FlexJS/src/mx/states/AddItems.js > >---------------------------------------------------------------------- > >diff --git a/frameworks/js/FlexJS/src/mx/states/AddItems.js > >b/frameworks/js/FlexJS/src/mx/states/AddItems.js > >index 6b1a347..3cf63a2 100644 > >--- a/frameworks/js/FlexJS/src/mx/states/AddItems.js > >+++ b/frameworks/js/FlexJS/src/mx/states/AddItems.js > >@@ -14,10 +14,13 @@ > > > > goog.provide('mx.states.AddItems'); > > > >+goog.require('org.apache.flex.core.IDocument'); > >+ > > > > > > /** > > * @constructor > >+ * @implements {org.apache.flex.core.IDocument} > > */ > > mx.states.AddItems = function() { > > }; > >@@ -25,19 +28,15 @@ mx.states.AddItems = function() { > > > > /** > > * @param {Object} document The MXML object. > >+ * @param {string=} opt_id The id. > > */ > >-mx.states.AddItems.prototype.setDocument = function(document) { > >+mx.states.AddItems.prototype.setDocument = function(document, opt_id) { > >+ opt_id = typeof opt_id !== 'undefined' ? opt_id : null; > > this.document = document; > > }; > > > > > > /** > >- * @type {string} document The type of override. > >- */ > >-mx.states.AddItems.prototype.type = 'AddItems'; > >- > >- > >-/** > > * @expose > > * @type {Object} document The MXML object. > > */ > >@@ -85,3 +84,25 @@ mx.states.AddItems.prototype.position = null; > > */ > > mx.states.AddItems.prototype.relativeTo = null; > > > >+ > >+/** > >+ * @expose > >+ * @param {Object} properties The properties for the new object. > >+ * @return {Object} The new object. > >+ */ > >+mx.states.AddItems.prototype.initializeFromObject = function(properties) > >{ > >+ var p; > > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
