Sorry, of course png is not the same.  
There is that black line across the "y".
I am using SvnDiff, which is also rather good (you can overlay, highlight 
diffs, etc...).

> If your code change didn't cause that bitmap to change why was a new baseline 
> image checked in?
As I said, because of the different XML DL dump, that contained references to 
ScrollableStageText (new class), so I checked in both.

I am not sure of that last point.
When a baseline provides both the bitmap and the xml DL, and the bitmap is the 
same, but the xml DL differs, 
Will the test fail, and generate .bad for both ? 

Maurice 

-----Message d'origine-----
De : Justin Mclean [mailto:jus...@classsoftware.com] 
Envoyé : mercredi 20 novembre 2013 01:16
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative 
FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be 
included in scrollable forms - updated mustella baseline bitmaps following 
failures. Typical difference is tha...

Hi,

> The png is the same

The png is not the same look at it before and after in that checkin. Before the 
underline is entirely white, after it is black where it crosses the "y".

Github has some nice way of checking for bitmap differences.

https://github.com/apache/flex-sdk/commit/9d6c2d34ed64be364ad30acfd0f2fe4f8ab2a12c?diff-0=3-0&diff-1=3-0&diff-2=3-0&diff-3=3-0&diff-4=3-0&diff-5=3-0&diff-6=3-0&diff-7=3-0&diff-8=3-0&diff-9=3-0&diff-10=3-0&diff-11=3-0

(look at very bottom image)

But I noticed the difference in Source Tree by looking and 'Preview before' and 
'Preview after' checkins of that image.

If your code change didn't cause that bitmap to change why was a new baseline 
image checked in?

Thanks,
Justin

Reply via email to