Hi,

Thanks for looking into it.

> Found some time to look.  Four of the five show antialiasing differences.
I checked in photoshop by putting the pairs of images on layers and doing a 
difference blend and there were no obvious changes.

> I'm not convinced the fonts are embedded correctly in these tests.
How do we check that?

>  One test (messageStyleName) seems to drop the last line of text?
In this case I think the current code is wrong as the text goes over the 
buttons.

>  One other(messageEmbedFont) has the text at a slightly different y position 
> as you
> mentioned.
Which I'm not sure why, given that all of the other tests have the text in the 
right position.

> Seems like some other logic may be busted in Alert.
Quite possible as previously the text could exceed the window bounds.

>  Might be a bigger mess that requires more than just this patch.
But this is an improvement of what already exists right?

Thanks,
Justin

Reply via email to