Hi Justin,

Ok, maybe better I revert and re-commit only the fix 
as and don't care about the useless, unused and confusing code, I'll do 
it tonight, no time at the moment.


> I can see than addFrame return type was modified but is this really needed?

IIRC, addFrame was returning always true, I guess it was due to a partly 
removed code which then created confusion and was useless, so, I cleaned the 
code removing the useless return statement and the function signature, so, no 
it wasn't necessary.

Thanks,
Frédéric THOMAS

> Subject: Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062: 
> FDB waits up to 20s per SWF before we can start debugging
> From: justinmcl...@me.com
> Date: Tue, 28 Jan 2014 00:21:50 +1100
> To: dev@flex.apache.org
> 
> Hi,
> 
> And for instance another concerning change - I can see than addFrame return 
> type was modified but is this really needed?
> -                                     if (addFrame(c))
> -                                             ++depth;
> -//                                   System.out.println("   
> this="+id+",@"+(bpi&0xffff)+":"+(bpi>>16)+",stack="+stack);
> +                    addFrame(c);
> +                                     ++depth;
> 
> Justin
                                          

Reply via email to