MD5 for the path is not a good idea. As you said, it makes it difficult to find and remove files.
So escaping and warning about the limit is fine. Maurice -----Message d'origine----- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 7 mars 2014 18:58 À : dev@flex.apache.org Objet : RE: [DISCUSS] Discuss Release Apache Flex SDK Installer 3.0 - RC4 ok -----Message d'origine----- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 7 mars 2014 18:51 À : dev@flex.apache.org Objet : Re: [DISCUSS] Discuss Release Apache Flex SDK Installer 3.0 - RC4 Hmm. Truncation could result in accidental cache collisions. There is already MD5 code in the app, maybe the safest thing to do is to generate an MD5 of the path/url. That would have the downside that it would be hard to go find and remove an individual file from the cache, which would be convenient for testing and also if a bad file gets in the cache. I think maybe the easiest path is to just escape and tell folks there is a 256 char limit (after escaping). If folks need to use a longer URL, they'll have to use a URL shortener or not turn on the cache. Thoughts? -Alex On 3/7/14 9:36 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote: >> We are not escaping the segments of the URL path expression. What >>you are seeing in the log is the File.url not File.nativepath. >Ah, ok so the native path has the "?" in it. > >>I guess I could escape everything including the slashes, then there >>wouldn't be subdirectories. That might be easier than other possible >>solutions. >Windows Doc says file paths are limited to 256 chars on Windows 7. >File names seem to have the same limit. >So that might be a good solution, and probably easier to browse, than >nested subdirectories that are currently created. >Since the path is used for identification of the file, you could also >truncate to the last 200 chars (in case it's too long, when appended to >the cache dir path) as the last chars are usually the most significant. > > >Maurice > >-----Message d'origine----- >De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 7 mars 2014 >18:25 À : dev@flex.apache.org Objet : Re: [DISCUSS] Discuss Release >Apache Flex SDK Installer 3.0 - RC4 > >We are not escaping the segments of the URL path expression. What you >are seeing in the log is the File.url not File.nativepath. > >I guess I could escape everything including the slashes, then there >wouldn't be subdirectories. That might be easier than other possible >solutions. > >Thoughts? >-Alex > >On 3/7/14 9:21 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote: > >>Alex, I suspected that too, so I tried to manually create a directory >>named: >>remotecontent%3ffilepath%3dcom >> >>And it was successfully created. >> >>However, creating remotecontent?filepath.com fails (? Is not allowed). >> >>Are you unescaping the file name before creating ? >> >>-----Message d'origine----- >>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 7 mars >>2014 >>18:12 À : dev@flex.apache.org Objet : Re: [DISCUSS] Discuss Release >>Apache Flex SDK Installer 3.0 - RC4 >> >>Yeah, looks like it can't create the file name because on windows it >>has illegal chars. Thanks for catching that. Looks like it is time >>for RC6! >> >>-Alex >> >>On 3/7/14 8:04 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> >>wrote: >> >>>Did the same test, with caching enabled, and verbose log enabled at >>>startup. >>>frozen at the same step (guava) : the busy indicator is running, but >>>nothing happens, even after 5 min. >>> >>>I have updated the log file at the same DP url. >>> >>>FYI no directory starting with remotecontent... is created under >>>flex_installer_cache (there are other directories such as air, dist, >>>download files, flex, etc...). >>> >>>Maurice >>> >>>-----Message d'origine----- >>>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 7 mars >>>2014 >>>16:50 À : dev@flex.apache.org Objet : Re: [DISCUSS] Discuss Release >>>Apache Flex SDK Installer 3.0 - RC4 >>> >>> >>> >>>On 3/7/14 7:41 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> >>>wrote: >>> >>>>Caching was on the first tests (failing)= Caching was off on the >>>>last tests (success). >>>>It's possible I turned verbose logging after the download started. >>>>Do you want me to try again, with caching, and setting verbose >>>>logging immediately? >>>Yes please. The log in your dropbox link did not show it running >>>through the caching logic or the verbose logging logic for the early >>>downloads. >>> >>>I just tried with caching on and off and it is working for me. >>> >>>Thanks, >>>-Alex >>>> >>>>Maurice >>>> >>>>-----Message d'origine----- >>>>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 7 mars >>>>2014 >>>>16:36 À : dev@flex.apache.org Objet : Re: [DISCUSS] Discuss Release >>>>Apache Flex SDK Installer 3.0 - RC4 >>>> >>>>Interesting. The log you posted doesn't show it running through the >>>>caching logic, and it just stops as if it didn't get a complete event. >>>> >>>>Are you sure caching was on? Or did you turn on verbose logging late? >>>> >>>>-Alex >>>> >>>>On 3/7/14 5:55 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> >>>>wrote: >>>> >>>>>I did another try disabling the download cache, and the >>>>>installation completes sucessfully. >>>>> >>>>>HTH. >>>>> >>>>>Maurice >>>>> >>>>>-----Message d'origine----- >>>>>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] >>>>>Envoyé : vendredi 7 mars 2014 14:47 À : dev@flex.apache.org Objet : >>>>>RE: [DISCUSS] Discuss Release Apache Flex SDK Installer 3.0 >>>>>- >>>>>RC4 >>>>> >>>>>I have tried Installer 3.0 RC4 with FlexJS Nightly / AIR 3.9 : >>>>> >>>>>I have used directories without spaces, including for download cache: >>>>>SDK target: D:\ApacheFlex\FlexJS\SDK Installer cache: >>>>>D:\Temp\flex_installer_cache Windows 7, fr >>>>> >>>>>Installer stops at guava downloading step (9th square) !! >>>>>Tried 3 times, always stops at the same step. >>>>> >>>>>Downloading guava directly from the browser works fine: >>>>>http://search.maven.org/remotecontent?filepath=com/google/guava/gua >>>>>v >>>>>a >>>>>/ >>>>>1 >>>>>5.0 >>>>>/guava-15.0.jar >>>>> >>>>>Here is the verbose install log: >>>>>https://www.dropbox.com/s/eiqzbvpuzxr67a3/FLEXJS_install_log_KO.txt >>>>> >>>>>Maurice >>>>> >>>>>-----Message d'origine----- >>>>>De : Kessler CTR Mark J [mailto:mark.kessler....@usmc.mil] >>>>>Envoyé : vendredi 7 mars 2014 13:26 À : dev@flex.apache.org Objet : >>>>>RE: [DISCUSS] Discuss Release Apache Flex SDK Installer 3.0 >>>>>- >>>>>RC4 >>>>> >>>>>How about just a busy indicator then while it's loading. It >>>>>doesn't require a language and is a universal graphic. >>>>> >>>>>-Mark >>>>> >>>>>-----Original Message----- >>>>>From: Alex Harui [mailto:aha...@adobe.com] >>>>>Sent: Thursday, March 06, 2014 7:40 PM >>>>>To: dev@flex.apache.org >>>>>Subject: Re: [DISCUSS] Discuss Release Apache Flex SDK Installer >>>>>3.0 >>>>>- >>>>>RC4 >>>>> >>>>> >>>>> >>>>>On 3/6/14 4:06 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote: >>>>> >>>>>>>> So, if we're going to do an RC5, what do we want to do about >>>>>>>> the >>>>>> >>>>>>> >>jumping: >>>>>>> >> >>>>>>> >> 1) nothing >>>>>>> >> 2) don't show any window at all (visible=false) until the >>>>>>> >> strings >>>>>>>are in >>>>>>> >> and the window is position. This could make start up seem >>>>>>>slower. >>>>>>> >> 3) don't reposition the window. >>>>>>> >> 4) other ideas? >>>>>>> >> >>>>>>> > >>>>>>> >Can we load the strings after the window center's itself on the >>>>>>>screen? >>>>>>> Also possible, but then the screen appears blank for a bit, then >>>>>>>the strings appear. >>>>>>> >>>>>>> Thoughts? >>>>>>> -Alex >>>>>>> >>>>>>> >>>>>>It appears blank initially anyways before the jump. At least if >>>>>>we center it right away, there wont be a jump. I think having it >>>>>>blank for a few seconds is okay. >>>>>> >>>>>>Maybe would could have all the dropdowns show a default label of >>>>>>"Loading..." so that it does not appear blank. >>>>>Interesting idea, but that will be in English since we are waiting >>>>>to load the default localized strings. Maybe I'll look into >>>>>putting up a busy cursor. >>>>> >>>>>-Alex >>>>> >>>> >>> >> >
