On Thu, Mar 13, 2014 at 11:57 AM, Alex Harui <aha...@adobe.com> wrote:
> My eyes cannot see the difference. The bug report says barely visible for > 320. Are you sure this is worth fixing for 240? > > Well, if you put it that way... its probably not worth it ;-) Should I just revert the changes for less than 320 DPI? > On 3/13/14 11:49 AM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote: > > >Thanks! Sure: > > > >640dpi: > >Before the fix = http://snag.gy/OMzJn.jpg (layoutCornerEllipseSize = 40) > >After the fix = http://snag.gy/q8jAp.jpg (layoutCornerEllipseSize = 28) > > > > > >On Thu, Mar 13, 2014 at 11:45 AM, Maurice Amsellem < > >maurice.amsel...@systar.com> wrote: > > > >> No objection for me. > >> > >> Can you send a high-DPI screenshot of the new button skins > >> > >> -----Message d'origine----- > >> De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > >>OmPrakash > >> Muppirala > >> Envoyé : jeudi 13 mars 2014 19:38 > >> À : dev@flex.apache.org > >> Objet : Re: flex-sdk_mustella-mobile - Build # 587 - Still Failing! > >> > >> Yup, that was the issue I was fixing. Clearly, the existing button > >> instances have this gap as well. They are more prominent in higher DPIs > >> [1] Which is why I am proposing to fix the baselines since they are > >> currently 'wrong'. > >> > >> Thanks, > >> Om > >> > >> [1] https://issues.apache.org/jira/secure/attachment/12631203/gap.png > >> > >> > >> On Thu, Mar 13, 2014 at 11:34 AM, Maurice Amsellem < > >> maurice.amsel...@systar.com> wrote: > >> > >> > Thanks. > >> > > >> > A few pixels difference in the rounded corners. > >> > > >> > Maurice > >> > > >> > -----Message d'origine----- > >> > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > >> > OmPrakash Muppirala Envoyé : jeudi 13 mars 2014 19:24 À : > >> > dev@flex.apache.org Objet : Re: flex-sdk_mustella-mobile - Build # > 587 > >> > - Still Failing! > >> > > >> > On Thu, Mar 13, 2014 at 9:13 AM, Maurice Amsellem < > >> > maurice.amsel...@systar.com> wrote: > >> > > >> > > >Any objections for recreating the baselines? > >> > > > >> > > What kind of difference between the old and new bitmaps? > >> > > Can you send sample bitmaps > >> > > > >> > > Maurice > >> > > > >> > > >> > > >> > From my sample mobile app, > >> > > >> > Before the change: http://snag.gy/xLulw.jpg (layoutCornerEllipseSize > = > >> > 15) After the change: http://snag.gy/vdjUZ.jpg > >> > (layoutCornerEllipseSize = > >> > 8) > >> > > >> > I will post more bitmaps from the Mustella tests soon. > >> > > >> > >
