On Tue, May 20, 2014 at 2:27 PM, Justin Mclean <jus...@classsoftware.com>wrote:

> Hi,
>
> >>    [java]
> gumbo/filters/ShaderFilter/Integration/ShaderFilter_integration
> >> integration_popup_test1 Failed CompareBitmap(body:step 1)  compare
> >> returned[object BitmapData]
> >>
> >>    [java]
> gumbo/filters/ShaderFilter/Integration/ShaderFilter_integration
> >> integration_popup_test2 Failed CompareBitmap(body:step 1)  compare
> >> returned[object BitmapData]
>
> Test fail nothing to do with shaders but to with an Alert popup due to the
> change I made the other day.
>
> In this case the alert text is a few pixels off in a very small dialog box
> - do we care about this?
>
>
No.


> We may be able to modify the tests so it's not explicitly setting height
> or setting the height to a larger number after showing the Alert.
>

+1 to modifying the baseline and not altering the test itself.

Thanks,
Om


>
> Thanks,
> Justin

Reply via email to