On 5/22/14 9:56 AM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> I think the textfield's gutter needs to be compensated for in this sort >>of >> fix. I'm wondering if it is as simple as allowing another 4 pixels in >> height before clipping so the top and bottom gutters are essentially >> ignored. > >That wouldn't fix the shader test. It's setting the Alert height too >small to properly contain all the content. Pervious it was just luck that >the text did not overlap as it has no defenders. In my results from the Shader test, the Alert is the same size, the button position appears to be the same, but in the baseline all the text shows, probably because the gutter of the TextField is under the button, but the text is fully visible. Luck or not, if other folks have controlled the size of the Alert (which is allowed) and it "just worked" for them, with these changes, it now will not. Right now, the changes won't let the gutter and button overlap. I'm wondering if you allow that, if these tests will pass and you can still clip. Another possible option is to only run the clipping code path if there is more than one line of text. -Alex
