And it looks like he didn't put the original commits into it's own branch and merge it over. That is the worst case, and caused me a bunch of headache.
-Nick On Mon, Jun 16, 2014 at 3:00 PM, OmPrakash Muppirala <bigosma...@gmail.com> wrote: > On Mon, Jun 16, 2014 at 11:57 AM, Erik de Bruin <e...@ixsoftware.nl> > wrote: > > > You are right. It took Om all of 6 min. - including writing the emails > ;-) > > > > Just kidding! > > > > EdB > > > > To be fair, it was a class that was untouched after Mike's commits. We got > lucky that the revert was easy in this case. > > Thanks, > Om > > > > > > > > > > > > On Mon, Jun 16, 2014 at 7:39 PM, Nicholas Kwiatkowski <nicho...@spoon.as > > > > wrote: > > > > > It's not always easy to revert when you merged a branch in GIT (and it > > > contained multiple commits), esp when the branch you merged no longer > > > exists. To say it only takes 5 minutes is not genuine... > > > > > > -Nick > > > > > > > > > On Mon, Jun 16, 2014 at 1:14 PM, Erik de Bruin <e...@ixsoftware.nl> > > wrote: > > > > > > > Yeah, as Om indicated on the other 'revert' thread, the committer > > should > > > > revert the vetoed commit himself. This should not take more than 5 > min. > > > (at > > > > most), so even replying to an email requesting a revert takes > longer... > > > > > > > > EdB > > > > > > > > > > > > > > > > > > > > On Mon, Jun 16, 2014 at 7:02 PM, Alex Harui <aha...@adobe.com> > wrote: > > > > > > > > > Mike gave us permission to revert. I hope to get to it this week > > > after > > > > > I get the FalconJX and FlexJS RCs out. > > > > > > > > > > From: Erik de Bruin <e...@ixsoftware.nl> > > > > > Date: Monday, June 16, 2014 1:22 AM > > > > > To: "Michael A. Labriola" <labri...@digitalprimates.net> > > > > > Cc: "dev@flex.apache.org" <dev@flex.apache.org>, aharui < > > > > aha...@adobe.com> > > > > > > > > > > Subject: Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - > Fix > > > for > > > > > issue FLEX-34320 > > > > > > > > > > And another week has gone by... > > > > > > > > > > Can you please revert, then discuss the proper solution? > > > > > > > > > > Thanks, > > > > > > > > > > EdB > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jun 9, 2014 at 4:39 PM, Michael A. Labriola < > > > > > labri...@digitalprimates.net> wrote: > > > > > > > > > >> >However much I'd like to "kill" a commit (or commit a kill?), > my > > > > >> very limited Git knowledge would surely bork the repo big time. > Can > > > you > > > > >> give me a pointer on how to safely handle this? > > > > >> > > > > >> > > > > >> > > > > >> No worries. I should be able to take care of it today if you > aren’t > > > > >> comfortable with it (and I don’t blame you). > > > > >> > > > > >> > > > > >> > > > > >> I just meant we could revert the commit I made in whatever way > makes > > > the > > > > >> most sense. I am not sure how much code has been committed since > > that > > > > time. > > > > >> > > > > >> > > > > >> > > > > >> Mike > > > > >> > > > > >> Notice: This transmission is intended only for the use of the > > > individual > > > > >> or entity to which it is addressed and may contain information > that > > is > > > > >> privileged or confidential. Any dissemination, distribution or > > copying > > > > of > > > > >> this transmission by anyone other than the intended recipient is > > > > strictly > > > > >> prohibited. If you have received this transmission in error, > please > > > > notify > > > > >> the sender immediately by e-mail or telephone and delete the > > original > > > > >> transmission. Thank you. > > > > >> > > > > > > > > > > > > > > > > > > > > -- > > > > > Ix Multimedia Software > > > > > > > > > > Jan Luykenstraat 27 > > > > > 3521 VB Utrecht > > > > > > > > > > T. 06-51952295 > > > > > I. www.ixsoftware.nl > > > > > > > > > > > > > > > > > > > > > -- > > > > Ix Multimedia Software > > > > > > > > Jan Luykenstraat 27 > > > > 3521 VB Utrecht > > > > > > > > T. 06-51952295 > > > > I. www.ixsoftware.nl > > > > > > > > > > > > > > > -- > > Ix Multimedia Software > > > > Jan Luykenstraat 27 > > 3521 VB Utrecht > > > > T. 06-51952295 > > I. www.ixsoftware.nl > > >
