Sorry, was sleepingŠ Things changed a couple of times so it is hard to keep track. For RC2 we were bundling GCL from the GOOG_HOME on the RMs machine. For the RC3 I am working on, I reverted that back to RC1 and 0.0.1 behavior where the installer.xml downloads it from somewhere. For RC3, it will download GCL from GH. You should see that in flex-asjs Git already.
Now, using that link to the master.zip is easy, except for how to checksum it. AIUI, as soon as someone makes a change to GCL and re-generates master.zip, it will break the FlexJS RC3 installer.xml It seems painful to have to maintain a checksum anywhere that checksums a repo. I wish they had a historical archive of zips so we could lock on one for a while just like we do for GCC. And if they check in something that breaks the compiler we've locked to, we'll get complaints from customers and won't have a way to move them back to a safe version. But I think moving the checksum to the -config.xml will at least make it easy for us to update instead of having it baked into installer.xml like it is now. Here's a thought though: Could we make our own fork of GCL on GH? Then we'd only refresh the fork from the true master when we feel good about it. Thoughts? -Alex On 6/27/14 3:48 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: >Ok, best as I can tell, the GCL in the binaries is taken from GOOG_HOME on >the machine on which the release is built. It is not actively pulled from >Git, unless it's built on our build VM using 'jenkins.xml'. > >Since the Installer uses the binaries, this means it never has to pull the >GCL sources itself, so it doesn't matter that the Installer cannot run >Git. > >EdB > > > > >On Fri, Jun 27, 2014 at 12:16 PM, Erik de Bruin <e...@ixsoftware.nl> >wrote: > >> exec. But I don't think we need it for GCC/GCL. I think I'm all set >>> until the GCL package on GH changes. >>> >> >> You should be able to always dl this zip: >> >> https://github.com/google/closure-library/archive/master.zip >> >> That is the only one that counts, as it basically contains the same >>files >> as the git clone does, namely the HEAD of the repo... There are no >> 'versions' of the GCL on GitHub per se. >> >> EdB >> >> >> >> -- >> Ix Multimedia Software >> >> Jan Luykenstraat 27 >> 3521 VB Utrecht >> >> T. 06-51952295 >> I. www.ixsoftware.nl >> > > > >-- >Ix Multimedia Software > >Jan Luykenstraat 27 >3521 VB Utrecht > >T. 06-51952295 >I. www.ixsoftware.nl
