I don't think we have a rule on it ATM. But for the SDK changes I usually close mine after a few days. This allows for any objections and/or Mustella breakages to appear.
-Mark -----Original Message----- From: Mihai Chira [mailto:mihai.ch...@gmail.com] Sent: Thursday, August 21, 2014 5:52 AM To: dev@flex.apache.org Subject: Re: [JIRA](ISSUE #FLEX-34119) Dev review request As far as I could tell mustella's tests weren't affected by the changes in HierarchicalCollectionViewCursor, HierarchicalCollectionView and LeafNodeCursor made to solve FLEX-34440, FLEX-34424, FLEX-34456, FLEX-34458, and the original FLEX-34119. I marked them all as resolved (including an extra one, FLEX-33054, which was describing one of the problems which caused FLEX-34119). What's the process by which we mark them as closed? For instance, do we do that once they make it into a release? On 11 August 2014 15:43, Mihai Chira <mihai.ch...@gmail.com> wrote: > Brilliant, let's see what happens. > > On 11 August 2014 15:41, Alex Harui <aha...@adobe.com> wrote: >> >> >> On 8/11/14 4:13 AM, "Mihai Chira" <mihai.ch...@gmail.com> wrote: >> >>>I just ran mustella for AdvancedDataGrid, which should be the only >>>component affected. Everything ran fine (Passes: 135, Fails: 0). I'm >>>going to merge the branch code with develop. I guess that's when >>>people can comment if they see any problems with the code. >> Awesome! I have my fingers crossed. >>> >>>When does the entire suite of mustella tests run in our CI? At every >>>commit, or nightly? >> I think hourly after a commit, and also once a day. >> >> -Alex >>
smime.p7s
Description: S/MIME cryptographic signature
