Hi Curtis, Yes I saw the JIRA notifications. I'm hoping to take a look in a day or two.
Thanks for your contributions, -Alex On 9/24/14 7:10 AM, "Curtis Aube" <curtis.a...@piematrix.com> wrote: >Alex, > >Alright, I added a patch to the same ticket (FLEX-34476). The RTE now >extends SkinnableComponent and includes a skin. >I could put it on a new ticket if that is preferable, but I figured I put >it there since that ticket is still open. >Justin Mclean is assigned to the ticket. > >Curtis > >On Sep 8, 2014, at 12:29 PM, Alex Harui <aha...@adobe.com> wrote: > >> Hi Curtis, >> >> Sounds great. Looking forward to another patch. >> >> -Alex >> >> On 9/8/14 8:13 AM, "Curtis Aube" <curtis.a...@piematrix.com> wrote: >> >>> Alex, >>> >>> It's seems that it should probably subclass SkinnableComponent as you >>> suggest. It keeps more with the spirit of Spark. >>> >>> I was actually planning on doing it but never got around to it. I was >>> sitting on the code for a while and figured I would submit it as is and >>> see if there was any demand for it before I spent the time to do it. >>> >>> I'd be happy to work on making it skinnable. >>> >>> Curtis >>> >>> On Aug 29, 2014, at 11:19 AM, Alex Harui <aha...@adobe.com> wrote: >>> >>>> Hey Curtis, >>>> >>>> First off, thanks for contributing a Spark RichTextEditor component. >>>> I'm >>>> sure others will find it useful as well, and the process you went >>>> through >>>> (filing a JIRA [1], submitting patches, tweaking the code) will serve >>>> as a >>>> good example for others who are wondering how to contribute to Apache >>>> Flex. >>>> >>>> I looked over the code the other day, and I have a question for you. >>>> I'm >>>> asking on the mailing list instead of directly in the JIRA so folks >>>>who >>>> don't normally watch JIRA can participate in the discussion as well. >>>> >>>> The question is: What factored into the decision to write Spark >>>> RichTextEditor in ActionScript and subclass Group? I saw that part of >>>> the >>>> reason is that you were having trouble adding an MXML component to the >>>> Spark namespace. But IMO, even if we work that out, there are at >>>>least >>>> two choices: 1) write it in MXML like the MX RichTextEditor, and 2) >>>> Write >>>> it in AS and subclass SkinnableComponent. >>>> >>>> IMO, the MX RichTextEditor was written in MXML to make it easy to >>>> reconfigure the UI. And in Spark, reconfiguration of the UI is >>>> generally >>>> done in the Skin which would then be a reason to subclass >>>> SkinnableComponent. Opinion from others is welcome here: if you were >>>>to >>>> use Spark RichTextEditor would you rather just copy and tweak an MXML >>>> file, or use the skinning workflow? >>>> >>>> Also, let us know if you have the cycles to keep making improvements >>>>to >>>> this component. As this is open-source, others can always pitch in to >>>> help, not only on this component, but any code in the project. And >>>> contributing code is a common way one becomes a committer on the >>>>project >>>> (which is generally a valuable thing to your employers and/or >>>>clients), >>>> although there is no guarantee. >>>> >>>> Thanks, >>>> -Alex >>>> >>>> [1] https://issues.apache.org/jira/browse/FLEX-34476 >>>> >>> >> >
