Hi,

I'm jet lagged and still travelling so please excuse any sillly mistakes I make 
here.

- LICENSE and NOTICE correct
- all source files have correct headers
- no binaries in release
- can compile from source

Only minor things I noticed where:
- The artefact name should have "apache" in it as this gives some extra legal 
protection, not required but it's a good idea.
- README has a couple of minor spelling errors

I also noticed a couple of things in the pom that may need fixing:
1. mailing list list user mailing list only, if only one mailing list is listed 
it probably should be the dev one
2. scm details look incorrect to me (looks like 
https://git-wip-us.apache.org/repos/asf/flex-utilities.git/tags/flex-tool-api-1.0.0-RC1
 doesn't exist and that would not be the final URL right?) Probably need to be 
fixed before releasing.
3. Does the target/source values of 1.6 mens it targeting Java 1.6? Should we 
be targeting 1.7?

Also while compiling I got this:
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/Users/justinmclean/Downloads/flex-tool-api-1.0.0/src/main/resources
[INFO] Copying 3 resources

Seems a little odd that it copies 3 resource but the resource directory doesn't 
exist.

Thanks,
Justin

Reply via email to