> Can you verify that the > change I made is still a valid fix? It was supposed to be an easy fix, it was obvious what was the issue, only the fix was badly applied, yours should do the trick, still waiting for the test case though.
Thanks, Frédéric THOMAS From: webdoubl...@hotmail.com To: dev@flex.apache.org Subject: RE: flex-sdk_mustella - Build # 1162 - Still Failing! Date: Thu, 20 Nov 2014 09:07:24 +0000 > A recent and seemingly correct change by Fred was the culprit. You can’t > do null tests on Strings and Numbers with just "if (foo)”. I’ve been > burned by this in the past. Sure, thanks for fixing that, I've been a bit too fast in doing it aparently :P > Fred, did you have a test case for FLEX-34611? No but asked the guy who reported to provide one. Frédéric THOMAS > From: aha...@adobe.com > To: dev@flex.apache.org; e...@ixsoftware.nl > Subject: Re: flex-sdk_mustella - Build # 1162 - Still Failing! > Date: Wed, 19 Nov 2014 23:30:03 +0000 > > I have found the problem. It would have saved me much time if I had > properly checked that TLF was in sync on my machine. > > A recent and seemingly correct change by Fred was the culprit. You can’t > do null tests on Strings and Numbers with just "if (foo)”. I’ve been > burned by this in the past. See end of post if you want more details: > > Fred, did you have a test case for FLEX-34611? Can you verify that the > change I made is still a valid fix? Or post the test case you used in the > JIRA issue and I’ll test it myself. > > I’ve re-enabled Jenkins. Cross your fingers for the next run! > > -Alex > > var foo:String; > if (foo) > trace(“foo is not null”) > foo = “”; > if (foo) > trace(“foo is not null”) > // neither trace statement is run because of [1] > > [1] > http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package. > html#Boolean() > [1] http://s.apache.org/26R > > >
