I'm fine with any solution, as long as the Falcon compiler is fine with it as well ;-)
EdB On Fri, Nov 21, 2014 at 10:09 AM, Piotr Zarzycki <piotrzarzyck...@gmail.com> wrote: > Hi Erik, > > In my opinion it looks a bit odd adding underscore to this variable. I > would suggest changing this to "tb_" -> "textBlock". Is there a code in TLF > where they are using such convention ? > > Piotr > > 2014-11-20 18:42 GMT+01:00 <erikdebr...@apache.org>: > > > Repository: flex-tlf > > Updated Branches: > > refs/heads/tables 41abfa4f4 -> a9a1f9e11 > > > > > > The local var had the same name as the function argument. The Falcon > > compiler objects to this ;-) > > > > Signed-off-by: Erik de Bruin <e...@ixsoftware.nl> > > > > > > Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo > > Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/a9a1f9e1 > > Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/a9a1f9e1 > > Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/a9a1f9e1 > > > > Branch: refs/heads/tables > > Commit: a9a1f9e11518a489af95f0eb781979c279e8c437 > > Parents: 41abfa4 > > Author: Erik de Bruin <e...@ixsoftware.nl> > > Authored: Thu Nov 20 18:42:09 2014 +0100 > > Committer: Erik de Bruin <e...@ixsoftware.nl> > > Committed: Thu Nov 20 18:42:09 2014 +0100 > > > > ---------------------------------------------------------------------- > > textLayout/src/flashx/textLayout/elements/ParagraphElement.as | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ---------------------------------------------------------------------- > > > > > > > > > http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/a9a1f9e1/textLayout/src/flashx/textLayout/elements/ParagraphElement.as > > ---------------------------------------------------------------------- > > diff --git > a/textLayout/src/flashx/textLayout/elements/ParagraphElement.as > > b/textLayout/src/flashx/textLayout/elements/ParagraphElement.as > > index 4ddd7c4..5f7cd09 100644 > > --- a/textLayout/src/flashx/textLayout/elements/ParagraphElement.as > > +++ b/textLayout/src/flashx/textLayout/elements/ParagraphElement.as > > @@ -222,9 +222,9 @@ package flashx.textLayout.elements > > return; > > } > > var tbs:Vector.<TextBlock> = getTextBlocks(); > > - for each(var tb:TextBlock in tbs) > > + for each(var tb_:TextBlock in tbs) > > { > > - releaseTextBlockInternal(tb); > > + releaseTextBlockInternal(tb_); > > } > > //_textBlock = null; > > if (_computedFormat) > > > > > > > -- > > Greetings > Piotr Zarzycki > > Flex/AIR/AngularJS Developer > > mobile: +48 880 859 557 > e-mail: piotrzarzyck...@gmail.com > skype: zarzycki10 > > LinkedIn: http://www.linkedin.com/piotrzarzycki <http://linkd.in/1aGNqao> > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
