thanks Alex, I'll try that out too. Dany
> Op 3-mrt.-2015, om 16:57 heeft Alex Harui <aha...@adobe.com> het volgende > geschreven: > > Congratulations! FWIW, for some (not all) code changes, you can try > setting the source-path to the src folder of a folder in > frameworks/projects. Or you can make your own folder tree in your > project’s source folder and make changes there. Source-path is always > supposed to override library-path in the compiler. Sometimes the > compiler won’t be able to resolve certain constants when you do that and > you have to drop back to the way you just did. But if it does work, it > can be the fastest way to try out changes. > > But the final test before submitting a patch is to make sure the full > build still works. > > Thanks, > -Alex > > On 3/3/15, 7:48 AM, "Dany Dhondt" <archeme...@mac.com> wrote: > >> >> Free beers and confetti for all :) >> Made my first patch file. >> >> Hi Eric, >> >> I forgot the caret :( >> >> Now the patch file is made and attached to ticket FLEX-34772 >> Thx for all the help! >> >> Dany >> >>> Op 3-mrt.-2015, om 16:24 heeft Erik de Bruin <e...@ixsoftware.nl> het >>> volgende geschreven: >>> >>> I think you have to pipe the output to a file: >>> >>> git diff frameworks/projects/spark/src/spark/layouts/ > fix.patch >>> >>> (I think, haven't use this IRL) >>> >>> EdB >>> >>> >>> >>> On Tue, Mar 3, 2015 at 4:15 PM, Dany Dhondt <archeme...@mac.com> wrote: >>>> Hi Eric, >>>> >>>> I'm afraid I need your help again. >>>> The docs say that I have to create a patch file from the root of the >>>> sdk. >>>> So, from flex-sdk, I tried this command: >>>> >>>> git diff frameworks/projects/spark/src/spark/layouts/ fix.patch >>>> >>>> What do I do wrong? >>>> >>>> Dany >>>> >>>>> Op 3-mrt.-2015, om 15:47 heeft Subs <subscripti...@leeburrows.com> >>>>> het volgende geschreven: >>>>> >>>>> Don't know if it's an option for you, but Intellij is a lot >>>>> better/nicer/easier than FB when it comes to stuff like this (building >>>>> the sdk, creating a patch etc). >>>>> >>>>> On 03/03/2015 14:32, Dany Dhondt wrote: >>>>>> Hi Eric, >>>>>> >>>>>> Solved! >>>>>> First, the change didn't show up. Then I ran the application and >>>>>> when I came back to FB, the change showed up! >>>>>> Pfewww! One more step: creating a patch file. That shouldn't be too >>>>>> hard I guess... >>>>>> >>>>>> So far so good. Many thanks for the help... >>>>>> >>>>>> Dany >>>>>> >>>>>>> Op 3-mrt.-2015, om 15:27 heeft Erik de Bruin <e...@ixsoftware.nl> >>>>>>> het volgende geschreven: >>>>>>> >>>>>>> Are you sure your project is using the repo SDK (I have to ask...)? >>>>>>> >>>>>>> EdB >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Mar 3, 2015 at 3:22 PM, Dany Dhondt <archeme...@mac.com> >>>>>>> wrote: >>>>>>>> Hi Eric, >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ok, I succeeded to add the repo sdk to Flash Builder. >>>>>>>> Now I changed a file in the repo (VerticalLayout.as), recompiled >>>>>>>> in the folder spark using ant main and cleaned my test project. >>>>>>>> >>>>>>>> The changes don't show up though. What am I doing wrong? >>>>>>>> >>>>>>>> thx again, almost there I think >>>>>>>> >>>>>>>> Dany >>>>>>>> >>>>>>>>> Op 3-mrt.-2015, om 14:41 heeft Erik de Bruin <e...@ixsoftware.nl> >>>>>>>>> het volgende geschreven: >>>>>>>>> >>>>>>>>> Nope, it doesn't, it just adds and creates the ones that need to >>>>>>>>> be there ;-) >>>>>>>>> >>>>>>>>> EdB >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Mar 3, 2015 at 1:06 PM, Dany Dhondt <archeme...@mac.com> >>>>>>>>> wrote: >>>>>>>>>> Hi Eric, >>>>>>>>>> >>>>>>>>>> So you mean I should do this?: >>>>>>>>>> >>>>>>>>>> sh makeApacheFlexForIDE.sh /ApacheFlex/source/flex-sdk >>>>>>>>>> >>>>>>>>>> Won't that overwrite all files there? >>>>>>>>>> >>>>>>>>>> Dany >>>>>>>>>> >>>>>>>>>>> Op 3-mrt.-2015, om 12:57 heeft Erik de Bruin >>>>>>>>>>> <e...@ixsoftware.nl> het volgende geschreven: >>>>>>>>>>> >>>>>>>>>>>> But my base flex-sdk folder can't be used in FB. So I created >>>>>>>>>>>> a second sdk folder using the makeApacheFlexForIDE command, >>>>>>>>>>>> right? >>>>>>>>>>>> So when I edit a file, it points to the one in the FB sdk, NOT >>>>>>>>>>>> to the sdk folder I cloned from git. >>>>>>>>>>> It is my understanding that the 'makeApacheFlexForIDE' command >>>>>>>>>>> prepares a specific directory. If you pointed it at the git >>>>>>>>>>> repo, that >>>>>>>>>>> repo should be usable in FB... >>>>>>>>>>> >>>>>>>>>>> EdB >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Ix Multimedia Software >>>>>>>>>>> >>>>>>>>>>> Jan Luykenstraat 27 >>>>>>>>>>> 3521 VB Utrecht >>>>>>>>>>> >>>>>>>>>>> T. 06-51952295 >>>>>>>>>>> I. www.ixsoftware.nl >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Ix Multimedia Software >>>>>>>>> >>>>>>>>> Jan Luykenstraat 27 >>>>>>>>> 3521 VB Utrecht >>>>>>>>> >>>>>>>>> T. 06-51952295 >>>>>>>>> I. www.ixsoftware.nl >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Ix Multimedia Software >>>>>>> >>>>>>> Jan Luykenstraat 27 >>>>>>> 3521 VB Utrecht >>>>>>> >>>>>>> T. 06-51952295 >>>>>>> I. www.ixsoftware.nl >>>>>> >>>>> >>>>> -- >>>>> Lee Burrows >>>>> ActionScripter >>>>> >>>> >>> >>> >>> >>> -- >>> Ix Multimedia Software >>> >>> Jan Luykenstraat 27 >>> 3521 VB Utrecht >>> >>> T. 06-51952295 >>> I. www.ixsoftware.nl >> >
