I want to fix this by getting HierarchicalCollectionView to refuse the opening of a node which cannot be seen (i.e. whose parent is not open, or whose parent's parent is not open, etc.) Can anyone think of reasons this is not a good idea? E.g. related to the functioning of AdvancedDataGrids?
Thanks. On 3 March 2015 at 17:40, <mih...@apache.org> wrote: > Repository: flex-sdk > Updated Branches: > refs/heads/develop b03e5100d -> cc2ccf6a0 > > > FLEX-34775 Added a unit test to reproduce the bug. > > > Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cc2ccf6a > Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cc2ccf6a > Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cc2ccf6a > > Branch: refs/heads/develop > Commit: cc2ccf6a0e689b5ea203712a3d3c2192d91ae418 > Parents: b03e510 > Author: Mihai Chira <mih...@apache.org> > Authored: Tue Mar 3 17:39:03 2015 +0100 > Committer: Mihai Chira <mih...@apache.org> > Committed: Tue Mar 3 17:39:03 2015 +0100 > > ---------------------------------------------------------------------- > ...erarchicalCollectionView_FLEX_34775_Tests.as | 79 ++++++++++++++++++++ > 1 file changed, 79 insertions(+) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cc2ccf6a/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionView_FLEX_34775_Tests.as > ---------------------------------------------------------------------- > diff --git > a/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionView_FLEX_34775_Tests.as > > b/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionView_FLEX_34775_Tests.as > new file mode 100644 > index 0000000..e4eeccd > --- /dev/null > +++ > b/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionView_FLEX_34775_Tests.as > @@ -0,0 +1,79 @@ > +//////////////////////////////////////////////////////////////////////////////// > +// > +// Licensed to the Apache Software Foundation (ASF) under one or more > +// contributor license agreements. See the NOTICE file distributed with > +// this work for additional information regarding copyright ownership. > +// The ASF licenses this file to You under the Apache License, Version 2.0 > +// (the "License"); you may not use this file except in compliance with > +// the License. You may obtain a copy of the License at > +// > +// http://www.apache.org/licenses/LICENSE-2.0 > +// > +// Unless required by applicable law or agreed to in writing, software > +// distributed under the License is distributed on an "AS IS" BASIS, > +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +// See the License for the specific language governing permissions and > +// limitations under the License. > +// > +//////////////////////////////////////////////////////////////////////////////// > + > +package mx.collections > +{ > + import org.flexunit.asserts.assertEquals; > + > + public class HierarchicalCollectionView_FLEX_34775_Tests > + { > + private static var _utils:HierarchicalCollectionViewTestUtils > = new HierarchicalCollectionViewTestUtils(); > + private static var _sut:HierarchicalCollectionView; > + private var _level0:ArrayCollection; > + > + [Before] > + public function setUp():void > + { > + _sut = generateHierarchyViewWithClosedNodes(); > + _level0 = _utils.getRoot(_sut) as ArrayCollection; > + } > + > + [After] > + public function tearDown():void > + { > + _sut = null; > + _level0 = null; > + } > + > + > + > + [Test] > + public function test_navigation_after_opening_hidden_node():void > + { > + //given > + var company:DataNode = _level0.getItemAt(0) as DataNode; > + var location:DataNode = company.children.getItemAt(0) as > DataNode; > + > + //when > + _sut.openNode(location); > + > + var cursor:IViewCursor = _sut.createCursor(); > + var i:int = 0; > + while(!cursor.afterLast && i++ < 100) > + { > + cursor.moveNext(); > + } > + > + //then > + assertEquals(1, i); > + assertEquals(1, _sut.length); > + } > + > + private static function > generateHierarchyViewWithClosedNodes():HierarchicalCollectionView > + { > + return > _utils.generateHCV(_utils.generateHierarchySourceFromString(HIERARCHY_STRING)); > + } > + > + private static const HIERARCHY_STRING:String = (<![CDATA[ > + Adobe > + Adobe->London > + Adobe->London->FlexDept > + ]]>).toString(); > + } > +} > \ No newline at end of file >
