Hi,

-1 binding due to binary files in source release (ant_on_air/tests/OSMF2_0.swc) 
and unable to compile from source.

For the source release (.tar.gz) I checked:
- signatures and hashes correct
- LICENSE and NOTICE are good
- README and RELEAE_NOTES are OK, release notes missing a few JIRAs (fixed)
- missing contributor files (fixed)
- There is a binary file in the source release (OSMF2_0.swc)
- All source files have Apache headers
- Unable to compile from source (see discussion)

For binary convince release
- signatures and hashes correct
- LICENSE was missing a few of the bundled bits (fixed).
- NOTICE ok
- Unable to install the latest Flex SDK

Some issues:
- Getting the installer to run is actually quite difficult due to the fact it 
is not signed, do we want to consider signing the application to get around 
this?
- Flash Player 18 / AIR 18 is out but the installer only allows you to install 
18 beta.
- When trying to install SDK 4.14.1 nothing happens after hitting the first 
next button. Log shows no errors but eventually times out. Ofter SDK versions 
don’t have this issue.
- Same issue with Flex JS 0.02. The “JBerg” version can progress.
- Installing Flex 4.13 seems to work end up mentioning Falcon / Falcon JX / 
Flex JS rather the the Flex SDK in the UI and log. May only happen if you 
select several products before deciding on Flex 4.13.

Log from install failure:
Installer version 3.2.0 (mac)
Using Locale: en_AU
Fetched the SDK download mirror URL from the CGI.
Timeout
Aborting Installation

Log form FlexJS/Falcon weirdness:
Installer version 3.2.0 (mac)
Using Locale: en_AU
Fetched the SDK download mirror URL from the CGI.
SDK version Apache Flex SDK 4.13.0
AIR version 16.0
Flash Player version 16.0
Creating Apache FlexJS home
Creating temporary directory
Downloading Apache Flex FalconJX Compiler 
from:http://archive.apache.org/dist/flex/4.13.0/binaries/apache-flex-sdk-4.13.0-bin.tar.gz
Verifying Apache Flex Falcon MD5 Signature
The Apache Flex Falcon MD5 Signature of the downloaded files matches the 
reference. The file is valid.
Unzipping: 
/Users/justinmclean/Documents/ApacheFlexTest/temp/apache-flex-sdk-4.13.0-bin.tar.gz
Finished unzipping: 
/Users/justinmclean/Documents/ApacheFlexTest/temp/apache-flex-sdk-4.13.0-bin.tar.gz
Downloading Adobe AIR Runtime Kit for Mac from: 
http://airdownload.adobe.com/air/mac/download/16.0//AdobeAIRSDK.tbz2
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/in/AdobeAIRSDK.tbz2
Finished untaring: 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/AdobeAIRSDK.tar
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/frameworks/libs/air to 
/Users/justinmclean/Documents/ApacheFlexTest/frameworks/libs
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/frameworks/projects/air 
to /Users/justinmclean/Documents/ApacheFlexTest/frameworks/projects
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/include to 
/Users/justinmclean/Documents/ApacheFlexTest
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/lib/android to 
/Users/justinmclean/Documents/ApacheFlexTest/lib
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/lib/aot to 
/Users/justinmclean/Documents/ApacheFlexTest/lib
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/lib/nai to 
/Users/justinmclean/Documents/ApacheFlexTest/lib
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/runtimes to 
/Users/justinmclean/Documents/ApacheFlexTest
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/samples/badge to 
/Users/justinmclean/Documents/ApacheFlexTest/samples
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/samples/icons to 
/Users/justinmclean/Documents/ApacheFlexTest/samples
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/templates/air to 
/Users/justinmclean/Documents/ApacheFlexTest/templates
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/templates/extensions to 
/Users/justinmclean/Documents/ApacheFlexTest/templates
Copying files from 
/Users/justinmclean/Documents/ApacheFlexTest/in/airsdk/templates/sdk to 
/Users/justinmclean/Documents/ApacheFlexTest/templates
Installing Adobe Flash Player playerglobal.swc from: 
http://download.macromedia.com/get/flashplayer/updaters/16//playerglobal16_0.swc
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/frameworks/libs/player/16.0/playerglobal.swc
Downloading 2.2.zip from: https://github.com/swfobject/swfobject/archive
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/in/swfobject_2_2.zip
Download complete
Downloading OSMF.swc from: 
http://downloads.sourceforge.net/project/osmf.adobe/OSMF%202.0%20Release%20%28final%20source%2C%20ASDocs%2C%20pdf%20guides%20and%20release%20notes%29
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/frameworks/libs/osmf.swc
Downloading afe.jar from: 
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/lib/external/optional/afe.jar
Downloading aglj40.jar from: 
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/lib/external/optional/aglj40.jar
Downloading flex-fontkit.jar from: 
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/lib/external/optional/flex-fontkit.jar
Downloading rideau.jar from: 
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/lib/external/optional/rideau.jar
Downloading flex-messaging-common.jar from: 
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib
Validating download: 
/Users/justinmclean/Documents/ApacheFlexTest/lib/external/optional/flex-messaging-common.jar
Installing frameworks configuration files configured for use with an IDE
/Users/justinmclean/Documents/ApacheFlexTest is now an IDE compatible folder
Installation complete.

I notice that FLexJS (with JBerg) is being downloaded from non Apache 
infrastructure. Wasn’t that just a temporary measure and was going to be fixed?
URL is currently 
http://apacheflexbuild.cloudapp.net:8080/job/FlexJS002Workaround/ws/apache-flex-flexjs-0.0.2-bin.tar.gz

Minor things:
- Do we need ./installer/deps/* files in the source release?
- Should ./installer/deps/as3corelib/README be renamed LICENSE so it's more 
obvious what it is?
- tar -xvf  unpacks to current directory which is little unexpected
- Year in NOTICE is not a range (fixed)
- Year in InstallApacheFlex-app.xml is 2014 (fixed)
- Year in build.number file is incorrect. Do we still need this? Should the 
build number be 0?
- Apache Flex 4.13 lists license agreement for SWFObject that is not really 
needed to be accepted by the user as it’s a comparable license.
- FlexJS lists Google Closure library as being needed to be accepted. It’s 
Apache licensed so that’s not required.(Same with SWFObject)

Thanks,
Justin


Reply via email to