On Fri, Jul 31, 2015 at 4:44 PM, Alex Harui <aha...@adobe.com> wrote:
> On 7/31/15, 4:19 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" > <omup...@gmail.com on behalf of bigosma...@gmail.com> wrote: > > >On Fri, Jul 31, 2015 at 4:14 PM, Justin Mclean <jus...@classsoftware.com> > >wrote: > > > >> Hi, > >> > >> > Well, given this is Apache, I would first start by double-checking the > >> > licensing and provenance of GCL. > >> > >> It Apache licensed [1] but is missing a NOTICE file. All external > >> contributors must sign a ICLA [2][3] so there less issues that your > >>average > >> github project there. There are some 3rd party bundled stuff here [4] > >> (don’t know if we need to bundle them however) which are licensed under > >> compatible licenses (Apache, BSD and MIT). So no issues I can see as > >>long > >> as the LICENSE/NOTICE is updated. > >> > >> > >Awesome. Thanks Justin, for taking a look at this. So, if no one else > >has > >objections, I will start with the changes to the build scripts and the > >LICENSE/NOTICE file. > > Do it! And yes, thanks to Justin for checking. > > -Alex > > > I have updated the build scripts, LICENSE and NOTICE files. Things seem fine running off of my (windows) machine. Can you please take a look to see if everything works as expected? One thing I couldn't figure out was should we remove the requirement to have a separate GOOG_HOME folder. Or should we get rid of the whole GOOG_HOME thing completely? Thanks, Om
