On 8/10/15, 11:05 AM, "Frédéric THOMAS" <[email protected]> wrote:
>I even removed the entire <library-path> section and I've have no
>compilation errors and the core tests passes, is that enough to ensure it
>can be safely removed ?
Well, try running ‘ant main’, then in examples/DataBindingTest run Ant
again and see if you get any errors or warnings. Maybe something changed
so that isn’t needed anymore. You might just want to use a new
compile-js-config.xml file.
>
>Another thing, I see that in BrowserEvent.js
>
>/**
> * @type {?goog.events.BrowserEvent}
> */
>org.apache.flex.events.BrowserEvent.prototype.wrappedEvent = null;
>
>There is no extern definition for the GCL, I type those as Object, is it
>fine ?
That file contains some dirty hacks, maybe we just won’t cross-compile it.
>
>I added some missing potentially other properties and functions to this
>class, one of them required an enum, instead, I did like that:
>
>package org.apache.flex.core.BrowserEvent {
>
>COMPILE::AS3
>internal class MouseButton {}
>
>COMPILE::JS
>public class MouseButton {
> public static const LEFT:MouseButton = new MouseButton(0, "LEFT");
> public static const MIDDLE:MouseButton = new MouseButton(1, "MIDDLE");
> public static const RIGHT:MouseButton = new MouseButton(2, "RIGHT");
>
> private var _index:uint;
> private var _name:String;
>
> public function MouseButton(index:uint, name:String):void {
> _index = index;
> _name = name;
>
> }
>
> public function get index():uint {
> return _index;
> }
>
> public function get name():String {
> return _name;
> }
>}
>}
>
>
>Is it ok or it is overkilling ?
What is the advantage of doing it this way?
Thanks for working on this,
Alex
