On Tue, Sep 8, 2015 at 10:23 AM, Alex Harui <aha...@adobe.com> wrote:
> OK, I pushed new packages that deal with most of these issues (comments > in-line). I’m still waiting to hear what others think we should do about > headers for the generated files (see ‘Headers in Generated JS files' > thread). And I’d like to replace the map image in FlexJSStore so I’m > looking for an AL-friendly US map. I’d use the map coordinates in the > USStatesMap example if it has the right licensing. > Sorry, I forgot to respond to your question. The co-ordinates for the US States map comes from: https://commons.wikimedia.org/wiki/File:Blank_US_Map.svg which is under a dual license of Creative Commons - Attribution Share Alike and GNU FDL. Thanks, Om > > On 9/4/15, 9:13 PM, "Justin Mclean" <jus...@classsoftware.com> wrote: > > >Hi, > > > >Just gave it a go and took a quick look at the release artefacts. > > > >I notice the installer is asking to accept the Apache Flex JS and SWF > >Object licenses, this isn’t required as they are permissive licensed > >software. > > I have removed swfobject from the check list. I think we decided to keep > the main package in the check list. At least, that’s the way the Apache > Flex SDK 4.14.1 works. > > > > >For Falcon JS source release: > >- The product name is possibly incorrect in the NOTICE file? > > Not sure what you saw but I didn’t see anything. We are calling the cross > compiler FalconJX (not FalconJS). > > >- The NOTICE year is incorrect. > >- Probably no need (and potentially confusing) to have multiple LICENSE > >and NOTICE files in the release > >- RELEASE_NOTES are not upto data > > Made changes for these three although volunteers are welcome to beef up > the release notes. > > > > >For Falcon JS binary release: > >- As for the source release above > >- Are we happy with the provenance of the files under /externs? (I assume > >so but just asking to be thorough) > > Yes. These come from Google. > > > > >For Flex JS source release: > >- NOTICE file contains wrong year > >- NOTICE file contains Google Closure Library. This is not required [1], > >but if they (correctly) had a NOTICE file it probably would be. > > Made changes for these. > > > > >In LICENSE we have: > >"Portions of frameworks/projects/HTML/src/defaults.css is based on > >designmodo’s (http://designmodo.com/flat-free/) Flat UI which is > >available under an MIT license.” > > > >However that file doesn’t exist. Several other defaults.css files exist > >but they have Apache headers not MIT ones. Is something missing from the > >source package? > > That was supposed to be Flat/src/defaults.css. There isn’t an MIT header > because it is mostly Apache Flex css with some css copied from flat-free > and some that mimics what flat-free does due to implementation differences > in our code. > > > > >Do we know the providence of the files in: > >./js/lib/google/closure-library/closure/goog/demos/emoji/ > > Don’t know. This comes from Google. Feel free to ask them. > > > > >Or this file - seems to be a phone coverage map? > >./images/support_map.png > > This came from Adobe. I plan to replace it, but it is still in the > current nightly. > > > > >There’s a fx symbol in these images. Adobe owns that trademark I think??? > >./flexjs/FlexJSStore/src/assets/logo_blue.png > >./flexjs/FlexJSStore/src/assets/logo_orange.png > > I’ll replace the logo tonight unless someone beats me to it. > > > > >There’s also a few "Copyright 2013 The Apache Software Foundation” in > >several build.xml files. > > I made changes to -app.xml files, but didn’t see any build.xml files with > copyrights in it. > > > > >For Flex JS binary release: > >- As for the source release above > >- There’s a large number of JS source files without Apache headers e.g. > >frameworks/projects/Binding/js/out/org/apache/flex/binding/ApplicationData > >Binding.js > > As mentioned above, waiting to hear what others want to do about this. > > > > >LICENSE is missing: > >- MIT licensed > >js/lib/google/closure-library/third_party/closure/goog/mochikit/async/defe > >rred.js and > >js/lib/google/closure-library/third_party/closure/goog/mochikit/async/defe > >rredlist.js > >- BSD licensed > >js/lib/google/closure-library/third_party/closure/goog/svgpan/svgpan.js > >- BSD licensed > >js/lib/google/closure-library/third_party/closure/goog/dojo/dom/query.js > >- BSD licensed > >js/lib/google/closure-library/third_party/closure/goog/jpeg_encoder/jpeg_e > >ncoder_basic.js > > Made changes to pick these up. > > Thanks again for digging through this stuff. > > -Alex > >
