Github user aharui commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152585318
Hi SlavaRa,
(Apologies if this gets posted twice. I think email replies as comments
isn't working)
Do you have a link that supports your claim that the compiler cannot
generate the correct optimization? This article seems to imply that it
can [1]
IMO, the string concatenation is easier to read. I would want to see
actual profiling that shows that the string concatenation is affecting
compile times in a significant way.
But the most important question to me is: Is there a reason you want to
work on the mxmlc compiler? The âfalconâ compiler in the flex-falcon
repo
is under much more active development and it would be lower risk to be
doing optimizations in that code base. The âfalconâ compiler is the
compiler for the new FlexJS framework and I believe there is still a
reasonable chance it could replace the mxmlc compiler in Flex SDKs some
day.
-Alex
[1]
http://stackoverflow.com/questions/1532461/stringbuilder-vs-string-concatenation-in-tostring-in-java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
