On 11/3/15, 3:43 PM, "Justin Mclean" <justinmcl...@me.com> wrote:
>Hi, > >> I am unable to find an event.js in the source package. What folder is >>it >> in? > >./externs/GCL/src/goog/events.as but the same would apply to any file >under /externs/GCL. > >> The LICENSE file should include the text: >> "The .as files in externs/GCL/src were hand-ported from the Google >> Closure Library which are available under Apache License 2.0." > >Can you explain why (preferably with links to policy) why should the >LICENSE include that text? My understanding is that the LICENSE is supposed to include pointers to non-ASF code, even if that code is under AL. A patch recommending that has been proposed but never applied to the how-to. I will go find the links if you can’t find it in the legal-discuss archives. While IMO this code in externs/GCL/src is actually ASF code, I was concerned that it would be mistaken to be 3rd party code so I opted to mention it where third-party code is typically mentioned. As always, it would have been more expedient for the community and more in compliance with our release processes for you to have found a way to provide this feedback before the RC was opened for voting. > >This seems a bit odd to me "hand-ported” implies to me that we've taken >someone else code and modified it. If the file was originally AL by >someone else then there's no need to add it to license [1] (but that’s >only a minor non blocking issue). If the copyright is owned by someone >else and that was removed then we potentially have a blocking issue. >[2][3] For sure, I agree with the basic principles you state. I believe the authors of events.js do not have copyright to the lines in these files. If you look at the content of events.as and compare it to events.js, events.as is so heavily modified by apache committers such that I don’t think the authors of events.js can truly lay claim to any significant portion of it. My understanding is that because events.js is also under AL, then the committers making the changes have copyright to their changes and the changes are so significant that the committers that made the changes have copyright and thus the ASF has license and the collective copyright. I could certainly be wrong about that so we can ask on legal-discuss if you want. I will note that the externs file for JQuery is also copyright Google Closure Authors, so I think they took the same position in creating their header-like files from works by Jquery authors. -Alex
