OK, thanks for looking through it.
I pushed some changes and started build #681. It might be a bit hard to
follow the NOTICE changes because I changed my mind a few times but I
think the net is that:
1) I switched back to using the default NOTICE from the repo as the NOTICE
for FalconJX. This should result int the original developer text being in
the package.
2) I added
"The flex-compiler-oem compiler contains code written by Jeff Dyer at:
Copyright Mountain View Compiler Company (1998-2003)."
to the main NOTICE and flex-compiler-oem.jar. We don’t really bundle “asc
compiler” in FalconJX, just a few files that are in the flex-compiler-oem
folders.
FWIW:
We don’t bundle compc from the Flex SDK, we build it ourselves from
different sources, but since we can’t tell what macromedia/asc files might
be associated with that NOTICE requirement I added it anyway.
The rest of the items about the falcon packages shouldn’t apply to this
release as we are only releasing the FalconJX packages.
I’ll cut an RC tomorrow unless you still have issues after these changes.
Thanks,
-Alex
On 11/9/15, 3:09 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi,
>
>Here’s the issues I currently see with the binary releases (taken form
>this nightly build) [16]
>
>For apache-flex-falconjx-0.5.0-bin:
>- NOTICE is missing original developer
>- NOTICE is missing parts from NOTICE contained in [1] + others (i.e. the
>original developer of the bundled software). Either that or the NOTICE in
>the jars is incorrect.
>- I’d also add (as we’re bundling compc.jar) (Just to be safe as it's
>hard to know if it includes that code or not).
>The asc compiler contains code written by Jeff Dyer at:
> Copyright Mountain View Compiler Company (1998-2003).
>
>For completeness I also looked at apache-flex-falcon-0.5.0-bin.tar.gz as
>at some point it will need to be fixed.
>
>NOTICE is missing parts from:
> - NOTICE contained in [2]
> - NOTICE contained in [3]
> - NOTICE contained in [4]
> - NOTICE contained in [5]
>
>All strictly speaking there several different products mentioned in
>NOTICE files should be added. As while the copyright holder may be the
>same the product name and years differ.
>
>I’m not sure how Apache 1.1 items should [4][5] be treated but as the
>terms are different from the 2.0 license I assume it the best way would
>be to placed them in LICENSE.
>
>LICENSE is also missing:
>- BSD licenses javacc [6]
>- MPL licensed saxon [7]
>- items bundled in xalan [8] (see *.LICENSE.txt files)
>- W3C licenses in xml commons [11][12]
>- MIT license for swfobject [13]
>
>Possibly these BSD need to be added to LICENSE or the files not
>included?? [14][15]
>
>Thanks,
>Justin
>
>1. compiler/generated/dist/sdk/ant/lib/falcon-flexTasks.jar
>2. compiler/generated/dist/sdk/lib-legacy/asc.jar
>3. compiler/generated/dist/sdk/lib-legacy/batik-all-flex.jar
>4. compiler/generated/dist/sdk/lib-legacy/external/commons-collections.jar
>5. compiler/generated/dist/sdk/lib-legacy/external/commons-discovery.jar
>6. compiler/generated/dist/sdk/lib-legacy/external/javacc.jar
>7. compiler/generated/dist/sdk/lib-legacy/external/saxon9.jar
>8. compiler/generated/dist/sdk/lib-legacy/external/xalan.jar
>9. compiler/generated/dist/sdk/lib-legacy/external/xercesImpl.jar
>10. compiler/generated/dist/sdk/lib-legacy/external/xercesPatch.jar
>11. compiler/generated/dist/sdk/lib-legacy/external/xml-apis-ext.jar
>12. compiler/generated/dist/sdk/lib-legacy/external/xml-apis.jar
>13.
>compiler/generated/dist/sdk/frameworks/javascript/FABridge/samples/fabridg
>e/swfobject/swfobject.js
>14. compiler/generated/dist/sdk/lib/external/antlr-LICENSE.html
>15. compiler/generated/dist/sdk/lib/external/jflex-COPYRIGHT
>16. http://apacheflexbuild.cloudapp.net:8080/job/flex-falcon/680/
>
