GitHub user ok-at-github opened a pull request:
https://github.com/apache/flex-sdk/pull/38
Update to FontAwesome 4.5
Currently only FontAwesome 4.2 is included in the SDK.
This pull request contains the updated font itself and the updated
AwesomeUtils.as.
If somebody could merge it, I'll test it by downloading the latest dev
build.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ok-at-github/flex-sdk patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-sdk/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 64216e91720cd818da9d478410a117619f7f0fa0
Author: Mihai Chira <[email protected]>
Date: 2015-12-03T14:19:50Z
FLEX-34979
CAUSE:
When the transition was made from the spark Sort and SortField extending
AdvancedStyleClient to implementing its interfaces, the omission was that only
IAdvancedStyleClient was implemented, as opposed to all three relevant
interfaces (IAdvancedStyleClient, IFlexModule, IMXMLObject). More specifically
the mustella failures reflected that the function initialized() wasn't present
anymore, as that function, called automatically by the framework, is
responsible for registering the Sort and SortField instances with the
IFlexModuleFactory implementor (FlexModuleFactory or SystemManager, etc.).
SOLUTION:
The spark versions of Sort and SortField now also implement IFlexModule and
IMXMLObject via AdvancedStyleClientImplementation.
NOTES:
-also cleaned some imports in AdvancedStyleClient.
commit d22d68726e271ac680efe56296270b4a68876d92
Author: Mihai Chira <[email protected]>
Date: 2015-12-08T15:45:49Z
FLEX-34979
CAUSE:
The transformation of the spark Sort and SortField from extending
AdvancedStyleClient to implementing its interfaces and using an instance of it
as a class member had some more bugs:
-the id setter didn't exist
-when AdvancedStyleClient dispatched an event, Sort / SortField didn't pick
up on it and dispatch forward
-When AdvancedStyleClient initialized it added itself as a styleClient to
the document. This is undesired for Sort and SortField because from then on the
style code would used the AdvancedStyleClient member instead of the Sort /
SortField instances, as before, which meant that their relevant functions (such
as setStyle or styleChanged) were never called.
SOLUTION:
-there is now an id setter in AdvancedStyleClientImplementation
-AdvancedStyleClient_ was introduced to be able to override some functions
of AdvancedStyleClient
-Sort and SortField now listen to the events dispatched via their
AdvancedStyleClient_ member and pass on the events if there's a listener for
them
-on initialization we now add the Sort / SortField instances as
styleClients to the document instead of their AdvancedStyleClient members,
which should now be hidden from any code interacting with Sort and SortField
(this is achieved in AdvancedStyleClient_)
-all the instances where AdvancedStyleClient interacted with the
StyleProtoChain using 'this' were changed into using the Sort / SortField
instances
NOTES:
-Since some of the public functions in AdvancedStyleClient (getStyle,
setStyle, styleChanged) are also called internally from other
AdvancedStyleClient functions (or could be, in the future), and we need them to
hit the Sort / SortField implementations instead, AdvancedStyleClient_ now
overrides those functions and makes sure that the Sort / SortField versions are
called.
-AdvancedStyleClient.setDeferredStyles() was made protected so that
AdvancedStyleClient_.as can override it to make sure that
StyleProtoChain.setStyle is always called referring to Sort or SortField
instead of the instance of AdvancedStyleClient_ they use internally.
commit 10a910ea280b7abec5c8afff4883a94360f701b0
Author: Mark Kessler <[email protected]>
Date: 2015-12-11T17:34:20Z
FLEX-34982: The styles will now fallback to assigning directly to the chart
directly if the style declaration was not found. This corrects RTE's that
occur later when the styles are referenced and do not perform null checks.
-Removed initStyles() method return values since they were not being
checked and it's only response was true. It's a private method, will not have
to worry about being overridden.
commit 881ea2c363e8ef5b9415051708348828861ef63a
Author: Alex Harui <[email protected]>
Date: 2015-12-14T23:56:23Z
Merge branch 'release4.15.0' into develop
commit c047236b5753f1c5ffc1e5c4d9a6c2e4ad706906
Author: Alex Harui <[email protected]>
Date: 2015-12-16T05:47:10Z
Merge branch 'release4.15.0' into develop
commit 994cbceded646ff328ca003c71c25c87766869df
Author: Mihai Chira <[email protected]>
Date: 2015-12-18T10:05:41Z
FLEX-34979 Adding Apache header.
commit 9c7d389d218b79a9a7d858cdcdd0130625c681c2
Author: Mihai Chira <[email protected]>
Date: 2015-12-18T11:22:52Z
FLEX-34625
Reverting unit test to pre-debug version.
commit e11ef417cc59e9146ec791c64e3a36b2a004e63a
Author: Mihai Chira <[email protected]>
Date: 2015-12-18T11:38:18Z
FLEX-34958
Removed sub-tasks, added two newly-resolved features and upgraded some
issues that were listed as bugs to the New Features heading.
commit dc86ad392716ccbaf1a2fdac90479240da04f53c
Author: Mihai Chira <[email protected]>
Date: 2015-12-18T11:40:39Z
FLEX-34958
Reordered new features by ticket number.
commit 7738c750e36be693076c191fc61cc8fa5c7ab132
Author: Mark Kessler <[email protected]>
Date: 2015-12-21T02:35:34Z
Moved the initStyles from the moduleFactory setter to the class
constructor. This resolved a bug with the styles only being attempted once.
commit 72f4d3936d8513b5953d0db1f14edab65e866839
Author: ok-at-github <[email protected]>
Date: 2015-12-21T13:17:28Z
Update AwesomeUtils.as
Update to AwesomeFonts 4.5
commit 38c1a7565a95baebcf68f664902424d1e4d40e11
Author: ok-at-github <[email protected]>
Date: 2015-12-21T20:31:50Z
Update to FontAwesome 4.5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
