This also means that we'll need to update this xml when we release a
new version of FlexUnit. Is there a way we could reference the
flexunit build.xml's
"${build.version}-${build.number}-flex_${build.sdk}" variables,
instead of having to maintain these manually?On 4 January 2016 at 14:31, Mihai Chira <mihai.ch...@gmail.com> wrote: > I was just about to make the same change in flexunit-tests.xml, nice! > Were the changes in FLEX_34625_Tests also necessary? In other words, > was UIImpersonator.testDisplay not an IFocusManagerContainer? That > would be odd. > > On 4 January 2016 at 07:59, <aha...@apache.org> wrote: >> Repository: flex-sdk >> Updated Branches: >> refs/heads/develop 5bd868ea7 -> db54a3f34 >> >> >> this got these test to pass on my mac >> >> >> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo >> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/db54a3f3 >> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/db54a3f3 >> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/db54a3f3 >> >> Branch: refs/heads/develop >> Commit: db54a3f34fb570557a24847224f50eab4c77bd82 >> Parents: 5bd868e >> Author: Alex Harui <aha...@apache.org> >> Authored: Sun Jan 3 22:58:15 2016 -0800 >> Committer: Alex Harui <aha...@apache.org> >> Committed: Sun Jan 3 22:58:15 2016 -0800 >> >> ---------------------------------------------------------------------- >> flexunit-tests.xml | 4 +++- >> .../spark/tests/spark/skins/spark/FLEX_34625_Tests.as | 10 +++++++--- >> 2 files changed, 10 insertions(+), 4 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/db54a3f3/flexunit-tests.xml >> ---------------------------------------------------------------------- >> diff --git a/flexunit-tests.xml b/flexunit-tests.xml >> index 6475956..dce8cc7 100644 >> --- a/flexunit-tests.xml >> +++ b/flexunit-tests.xml >> @@ -77,6 +77,7 @@ >> toDir="${tests.bin}/report" >> haltonfailure="false" >> verbose="true" >> + debug="true" >> localTrusted="true"> >> >> <source dir="${project.root}/src"/> >> @@ -85,7 +86,7 @@ >> <include name="**/*Tests.as"/> >> </testSource> >> >> - <library dir="${FLEXUNIT_HOME}/FlexUnit4/target"/> >> + <library >> file="${FLEXUNIT_HOME}/FlexUnit4/target/flexunit-4.3.0-20140410-flex_4.12.0.swc"/> >> <library dir="${FLEXUNIT_HOME}/FlexUnit4CIListener/target"/> >> </flexunit> >> </target> >> @@ -96,6 +97,7 @@ >> toDir="${tests.bin}/report" >> haltonfailure="false" >> verbose="true" >> + debug="true" >> localTrusted="true"> >> >> <source dir="${project.root}/src"/> >> >> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/db54a3f3/frameworks/projects/spark/tests/spark/skins/spark/FLEX_34625_Tests.as >> ---------------------------------------------------------------------- >> diff --git >> a/frameworks/projects/spark/tests/spark/skins/spark/FLEX_34625_Tests.as >> b/frameworks/projects/spark/tests/spark/skins/spark/FLEX_34625_Tests.as >> index c040b38..fb0cbac 100644 >> --- a/frameworks/projects/spark/tests/spark/skins/spark/FLEX_34625_Tests.as >> +++ b/frameworks/projects/spark/tests/spark/skins/spark/FLEX_34625_Tests.as >> @@ -40,7 +40,11 @@ package spark.skins.spark { >> [Before] >> public function setUp():void >> { >> - var _focusManager:FocusManager = new >> FocusManager(UIImpersonator.testDisplay as IFocusManagerContainer); >> + var _focusManager:FocusManager; >> + if (UIImpersonator.testDisplay is IFocusManagerContainer) >> + _focusManager = new FocusManager(UIImpersonator.testDisplay >> as IFocusManagerContainer); >> + else >> + _focusManager = >> UIImpersonator.testDisplay.parent["document"].focusManager; >> _focusManager.showFocusIndicator = true; >> >> _textInput = new TextInput(); >> @@ -59,7 +63,7 @@ package spark.skins.spark { >> public function test_focus_skin_with_zero_focus_thickness():void >> { >> //given >> - UIImpersonator.addChild(_textInput); >> + UIImpersonator.addElement(_textInput); >> >> //when >> _textInput.setStyle("focusThickness", 0); >> @@ -75,7 +79,7 @@ package spark.skins.spark { >> public function test_focus_skin_with_NaN_focus_thickness():void >> { >> //given >> - UIImpersonator.addChild(_textInput); >> + UIImpersonator.addElement(_textInput); >> >> //when >> _textInput.setStyle("focusThickness", NaN); >>
