Github user adufilie commented on the pull request:
https://github.com/apache/flex-falcon/pull/5#issuecomment-169140272
I believe the patched code does the right thing. From the AS3 language
reference:
>Note: Methods of the Object class are dynamically created on Object's
prototype. To redefine this method in a subclass of Object, do not use the
override keyword. For example, a subclass of Object implements function
toString():String instead of using an override of the base class.
Therefore, the generated Object.as should not define toString().
Also, here's the description of the AS3 namespace:
>Defines methods and properties of the core ActionScript classes that are
fixed properties instead of prototype properties. When you set the "-as3"
compiler option to true (which is the default setting in Flex Builder 2), the
AS3 namespace is automatically opened for all the core classes. This means that
an instance of a core class will use fixed properties and methods instead of
the versions of those same properties and methods that are attached to the
class's prototype object. The use of fixed properties usually provides better
performance, but at the cost of backward compatibility with the ECMAScript
edition 3 language specification (ECMA-262).
It's a specific feature about gaining performance in Flash Player, and
should not be a part of js.swc, which is meant to be an API for JavaScript.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
