Hmmm ... could the Testcase be changed to  be self sufficient? The problem is 
that this would create the following chain of dependencies:

Falcon-JX --> Extern GCL --> Falcon

The problem with this is that Flacon and FalconJS are in the compiler "domain" 
and the externs in the "extern" domain and we get a cycle "compiler" --> 
"extern" --> "compiler". So we get a domain-cycle, which is rather undesirable. 
If however the  base class was provided as part of the test, this would 
eliminate this cycle of domains, make the test a true unit-test, cause this way 
this test is more an integration-test.

Chris
________________________________________
Von: Alex Harui <aha...@adobe.com>
Gesendet: Freitag, 6. Mai 2016 17:05:30
An: dev@flex.apache.org
Betreff: Re: AW: [Falcon] Failing test in TestGoogEmitter

On 5/6/16, 7:50 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:

>...ähm ... so it's probably NOT related to work i did ;-)

Sidebar: You have an interesting way of motivating people to help you.
The sentence above reads: "It can't be my fault so it must be your fault,
so now help me".  Whether you made the commit or I did, just about every
change in the past month has been attributed to work you have wanted to
see done.  I am trying to collaborate with you because we all agree on the
final goal, but IMO, your choices of words are not collaborative.

Now back to the technical question:  For me JSGoogDocEmitter.java:152
could throw an NPE if the base class isn't resolved.  In
TestGoogEmitter.testSimple, the base class is EventTarget, which comes
from the GCL.swc in the externs/GCL folder in flex-falcon.  I've had to
change install scripts because of the changes we made to flex-falcon and
flex-asjs, so it could certainly be that IntelliJ isn't currently working,
but are any of the Ant scripts in play in your test setup?

HTH,
-Alex

Reply via email to