Hi Alex,
I was confused how your changes fixed some things and investigated the reason. I refactored the dependencies completely and now the problems you patched with your changes are fixed on a conceptual level. Thanks for finding that. I went though all generated config files (Yes they were quite a lot) and I noticed some more things that needed some cleaning up which I did while I was at it. The reason the compiler isn't failing, was that I intentionally made the FlexJS compiler not fail because of the extension-generation that has to accept errors for now. I changed the code to Fail if errors in all steps except the js generation occur, but have disabled that check for now in order to not break the build. Especially thinking about the remove-circulars errors which still seem to produce valid JavaScript applications. Currently I am going through each compiler error and trying to fix them. I hope I'll be able to finish that tomorrow. The compiler option "remove-circulars" doesn't seem to be configurable via config-xml. I wouldn't like to start passing config options to commandline and config-xml. Would it be possible to extend the config.xml with this option? Thanks again for your help Alex, woking on this together definitely was a huge help ... now it's hopefully just one more step [?] ... Looking forward to doing some fun stuff after that ... like extending Maven [?] Chris ________________________________ Von: Alex Harui <aha...@adobe.com> Gesendet: Mittwoch, 29. Juni 2016 17:24:43 An: dev@flex.apache.org Betreff: Re: AW: [Falcon][FlexJS] Help with finishing the maven migration OK, I checked in some changes that got DataBindingExample to work in js-debug. Three things that probably need Chris to look at: 1. Maven doesn't report failure when compile errors are reported. DragDrop, HTML, CreateJSExample, FlexStore_JQuery (probably others) have errors. The changes I just committed fix the errors for DragDrop and HTML, but CreateJSExample and FlexStore_JQuery should still report errors. 2. CreateJSExample may need the createjs externs swc from flex-falcon, FlexStore_JQuery needs the jquery externs swc from flex-falcon. Other examples may need an externs swc from flex-falcon as well. 3. Many examples are reporting circular dependencies and the -remove-circulars compiler option should be set on those examples. HTH. Feels like were are almost there! -Alex On 6/29/16, 7:16 AM, "Alex Harui" <aha...@adobe.com> wrote: >I'm looking into the maven results today. > >-Alex > >On 6/29/16, 12:38 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote: > >>So if you guys could have a look at the results of the build: >> >>https://builds.apache.org/view/E-G/view/Flex/job/flex-asjs%20(maven)/ws/ >> >>There in the examples/flesjs/*Example/target/*Example-0.7.0-SNAPSHOT.war >>should be the zipped up result of the examples. Eventually it's something >>simple that is preventing the examples from running. >> >> >>As soon as that's done then I think we could do a 0.7.0 release. I would >>however like to do a dry-run cause I don't know if we need to release the >>mavenizer first. >> >> >>The thing missing in the mavenizer would be to support the >>auto-downloading of the debug flashplayer. That's already working, but >>not for Mac as I have to implement something to unpack DMG images (As >>every officially available lib is GPL). >> >> >>My next steps after that would be to help in the Apache Maven project >>(eventually I'll do that first) in order to introduce a new concept to >>maven that would allow us to handle and define the scopes of flex without >>hacks. >> >>As soon as that's done could concentrate on optimizing the >>flexjs-maven-plugin to utilize these new features. >> >> >>Chris >> >>________________________________ >>Von: Christofer Dutz <christofer.d...@c-ware.de> >>Gesendet: Mittwoch, 29. Juni 2016 07:26:49 >>An: dev@flex.apache.org >>Betreff: AW: [Falcon][FlexJS] Help with finishing the maven migration >> >>Did you get any errors? The builds on my machine and the asf Jenkins seem >>to be running nicely. >> >>Chris >> >> >> >>Von meinem Samsung Galaxy Smartphone gesendet. >> >> >>-------- Urspr?ngliche Nachricht -------- >>Von: Harbs <harbs.li...@gmail.com> >>Datum: 28.06.16 20:35 (GMT+01:00) >>An: dev@flex.apache.org >>Betreff: Re: [Falcon][FlexJS] Help with finishing the maven migration >> >>FWIW, we tried using Maven to build from source today (using the >>instructions at the top of this thread). I think it built Falcon, but we >>did not get anything in falcon-jx. >> >>On Jun 28, 2016, at 3:18 PM, Christofer Dutz <christofer.d...@c-ware.de> >>wrote: >> >>> Ok so I just pushed some changes that now not only build the flash >>>versions of the examples, but also JavaScript versions. Besides >>>producing a "target/javascript" directory, the build also zips the >>>content of the "js-debug" or "js-release" directory (depending on if >>>debug is true or false) as a war archive. With this we could have the >>>javascript client automatically bundled with a server application by >>>using WAR overlays [?] >>> >>> >>> Unfortunately there seems to be one or two things that aren't working >>>correctly as the output doesn't seem to run in the browser - At least in >>>Chrome, which I tested with: >>> >>> >>> Uncaught TypeError: Cannot read property 'Event' of undefined >>> Uncaught TypeError: Cannot read property 'EventTarget' of undefined >>> Uncaught TypeError: Cannot read property 'fireListener' of undefined >>> Uncaught TypeError: org.apache.flex.events.EventDispatcher.base is not >>>a function >>> >>> Chris >>> >>> ________________________________ >>> Von: Alex Harui <aha...@adobe.com> >>> Gesendet: Montag, 27. Juni 2016 09:06:18 >>> An: dev@flex.apache.org >>> Betreff: Re: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with >>>finishing the maven migration >>> >>> >>> >>> On 6/26/16, 1:00 AM, "Christofer Dutz" <christofer.d...@c-ware.de> >>>wrote: >>> >>>> Hi Alex, >>>> >>>> >>>> But before releasing the maven support officially, I would like to >>>>finish >>>> the JS output for SWFs first. >>> >>> Definitely. There is plenty of stuff to check while you are doing >>>that. >>> I'll probably send out a reminder LAST CALL on my Monday. >>> >>> -Alex >>> >> >
