I just pushed another change that will hopefully fix this problem and not break anything. All tests passed.
-Alex On 7/18/16, 2:22 AM, "Harbs" <harbs.li...@gmail.com> wrote: >I tried looking at what you did there, and I have no clue… ;-) > >On Jul 18, 2016, at 7:28 AM, Alex Harui <aha...@adobe.com> wrote: > >> This is probably related to the change that fixed the assignment to an >>XML >> variable. >> >> -Alex >> >> >> On 7/17/16, 11:18 AM, "Harbs" <harbs.li...@gmail.com> wrote: >> >>> I think it’s supposed to compile it correctly when >>> -compiler.strict-xml=true is set. >>> >>> It looks like it’s set in the build.xml file in XMLJS, but the output >>> does not look like it. >>> >>> Something also changed recently with how ant works. It used to work >>>that >>> I could build both the swcs and generated sources using the main >>>project >>> files (i.e. I could run ant in Core, and it would build everything I >>> need). It now looks like the compiler needs to be invoked separately on >>> the main project folders and the js folders? This makes my process more >>> difficult. How do I build all the assets of a single project in one go? >>> >>> I have no clue when exactly this changed, but I’m pretty sure it worked >>> before I checked out the latest source today and wiped falcon and “ant >>> alled” asjs. >>> >>> On Jul 17, 2016, at 8:53 PM, Josh Tynjala <joshtynj...@gmail.com> >>>wrote: >>> >>>> I moved some classes out of Core into a new project named Language >>>>that >>>> doesn't have any framework stuff in it (so that pure AS projects don't >>>> see >>>> classes that they don't need). I added Language as a new dependency to >>>> the >>>> config for XML, but I don't think this change would affect the >>>>generated >>>> code at all. >>>> >>>> - Josh >>>> >>>> On Jul 17, 2016 8:54 AM, "Harbs" <harbs.li...@gmail.com> wrote: >>>> >>>>> It looks to me like something broke. >>>>> >>>>> The compiler is interpreting XML internals as if they are XML >>>>>objects. >>>>> For >>>>> example, in XML.child(): >>>>> list.targetObject = this; >>>>> list.targetProperty = propertyName; >>>>> becomes : >>>>> list.setChild('targetObject', this); >>>>> list.setChild('targetProperty', propertyName); >>>>> >>>>> Which is obviously very bad… >>>>> >>>>> Harbs >>> >> >