I don't know what fix is needed for NPM, but based on the questions Om is asking, I doubt the NPM fix will affect the Maven jars.
It will, however, mean that if you publish artifacts before Om fixes NPM, I won't be able to use whatever tag you give me since I will use the later commit from Om when building the source package. So, IMO, up to you if you want get started now, although I did see that Josh checked in something to the develop branch which is not in the release branch. -Alex On 8/22/16, 1:22 PM, "Christofer Dutz" <[email protected]> wrote: >Aaaahh ... I think I just misunderstood you. I thought you added some >changes to the compiler defaults. Yes, we did clean up quite a bit there. >But the changes I did should probably only have an effect on Maven >builds. So I guess we're on the safe side from the Maven point of view. > > >Chris > >________________________________ >Von: Josh Tynjala <[email protected]> >Gesendet: Montag, 22. August 2016 22:15:35 >An: [email protected] >Betreff: Re: FlexJS 0.7.0 - NPM installation issues > >Chris, I'm guessing you don't need to do anything because I think you and >Alex were working together on the various changes. However, I don't follow >the Maven stuff closely enough to know for sure. > >Basically, instead of hard-coding certain compiler options in the >executable scripts in js/bin, they now specify a +configname option to >tell >the compiler to load the default options from one of the *-config.xml >files >in the frameworks directory. > >Here is the relevant line of js/bin/asjsc in Apache FlexJS 0.6: > >java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" >-Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME/../lib/mxmlc.jar" >+flexlib="$FLEX_HOME/frameworks" -js-output-type=jsc >-external-library-path="$SCRIPT_HOME/../libs/js.swc" "$@" > >And js/bin/asjsc from the 0.7 nightly: > >java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" >-Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME/../lib/mxmlc.jar" >+flexlib="$FLEX_HOME/frameworks" -js-output-type=jsc +configname=js "$@" > >+configname=js tells the compiler to load frameworks/js-config.xml. The >external-library-path option that was hard-coded in js/bin/asjsc in 0.6 is >now specified in js-config.xml. I think there are some other options that >are different from the default flex-config.xml too. > >asnodec, as another example, used to add both js.swc and node.swc to the >external-library-path in the executable script, but now it specifies >+configname=node, which loads frameworks/node-config.xml. > >Ultimately, this will make maintenance of the NPM version easier because >any new compiler options will be picked up automatically in the >*-config.xml files. It also means that compiler options used by the Shell >scripts (Unix) or Batch files (Windows) won't get out of sync because >they're now specified in one place only. > >- Josh > >On Mon, Aug 22, 2016 at 12:47 PM, Christofer Dutz ><[email protected] >> wrote: > >> Will this have an effect on the Maven Plugin? >> >> >> Chris >> >> ________________________________ >> Von: Josh Tynjala <[email protected]> >> Gesendet: Montag, 22. August 2016 17:09:03 >> An: [email protected] >> Betreff: Re: FlexJS 0.7.0 - NPM installation issues >> >> One more thing that will be easy to miss: >> >> The executable files like asjsc in js/bin have been tweaked a bit to >> include different default compiler arguments. The NPM exectuables like >> asjscnpm will need those same tweaks. >> >> - Josh >> >> On Fri, Aug 19, 2016 at 3:44 PM, OmPrakash Muppirala >><[email protected] >> > >> wrote: >> >> > I just tried the rc release with the current npm installation setup. >> > >> > First issue I see is this: >> > >> > >> > Error: ENOENT: no such file or directory, scandir >> > 'C:\Users\omuppirala\AppData\Roaming\npm\node_modules\ >> > flexjs\downloads\falcon\compiler\generated\dist\sdk\bin' >> > >> > In 0.6.0, we were copying files from the >> > '...\downloads\falcon\compiler\generated\dist\sdk\bin' directory. Did >> > that >> > get moved? >> > >> > Thanks, >> > Om >> > >>
