Hi Alex,
thanks for your responses. Well I made it check the closureLib as I wanted to
allow users to specify that if they wanted to monkey-patch stuff.
Well for now I removed the VF2JS stuff in my branch. I think I remember us
discussing that and that consensus was to remove the code.
At least with my last commits I managed the release build to work and I no
longer dump the closure stuff to release.
Chris
Am 31.10.16, 15:46 schrieb "Alex Harui" <aha...@adobe.com>:
On 10/31/16, 1:14 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:
>My optimization should have an effect if the closureLib is NOT explicitly
>set and the file „goog/deps.js“ is found on the compilers classpath. This
>is probably only the case for Maven builds.
I think closureLib is sometimes set for me. Any reason not to just rely
on whether you find deps.js on the class path?
>
>Currently the release build doesn’t kick in at all, even for a Maven
>build. I am hoping to fix this today after I understood the class a
>little better.
I assume you know that the release build is contingent on the -debug flag.
Is there more to it than that?
>
>Currently it seems as if for a debug build closure is only needed for
>dumping the dependency js files to the debug directory - is that correct?
The Closure Compiler? I wasn't aware it was used at all for debug builds,
but I don't know this code in detail.
Closure Library is needed to run the goog.provide and goog.require and
goog.events code.
>The actual closure compiler kicks in with compiling only for the release
>build – is that correct?
That's my understanding.
>If this is correct, why is the closure code dumped to the debug and the
>release directory?
Don't know. I don't see the closure library code in the bin/js-release.
Does the Closure Compiler compile in-place and remove files?
-Alex
