Hi Chris, I think rat.txt file is very useful, for example, when we forgot to put the license on a class, it quickly raise in that file, so I think we should maintain as it's now.
Thanks 2016-12-21 20:05 GMT+01:00 Christofer Dutz <christofer.d...@c-ware.de>: > Maven only cleans up it’s own stuff. So if you do something with Maven, > this is automatically guaranteed to be cleaned up, but if you do stuff with > Ant for examople (or use the „sonar-runner.bat“ to do a sonarqube check) > then this might leave files which maven doesn’t know about. Therefore rat > complains. I think it’s a good thing as when enabling the plugin I had to > update a huge amount of files manually. This way the contributor is > immediatley made aware of the problem that otherwise someone else will have > to do for him. > > In general I think we should all just know to look at the rat.txt in case > of a failure and that is guaranteed to contain all information you need. > But if the others agree, I could just make it run in the release profile > ... but that would bring up licensing issues at release preparation time. > > Chris > > Am 21.12.16, 19:12 schrieb "omup...@gmail.com im Auftrag von OmPrakash > Muppirala" <omup...@gmail.com im Auftrag von bigosma...@gmail.com>: > > On Dec 21, 2016 9:52 AM, "Alex Harui" <aha...@adobe.com> wrote: > > > > On 12/21/16, 9:10 AM, "omup...@gmail.com on behalf of OmPrakash > Muppirala" > <omup...@gmail.com on behalf of bigosma...@gmail.com> wrote: > > >Chris, any chance we can disable the rat check by default? I got hit > by > >that as well. Seems like a common place that could trip people up. > > The Rat check is useful. It helps make sure things are cleaned up > properly. I have a two separate working copy of the repos. I build > Ant > in one and Maven in the other. > > I see. So if the mvn clean goes well, the rat check should always > pass? > > > > > > HTH, > -Alex > > > -- Carlos Rovira Director General M: +34 607 22 60 05 http://www.codeoscopic.com http://www.avant2.es Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o confidencial. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la prestación del servicio o información solicitados, teniendo usted derecho de acceso, rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación necesaria.
