On 12/29/16, 9:41 AM, "piotrz" <piotrzarzyck...@gmail.com> wrote:
>Hi Carlos, > >Since I've finished Snackbar I can take next task. :) I see that Menu need >to be updated with dataProvider and item renderer API. >I will probably go same direction as you went with Lists - using >ISelectionModel. I'm going also introduce in "core" package MenuEvent with >ITEM_CLICK constant and new controller which handle click on menu item. You can totally ignore this if you want, but I would like to see us avoid using "click" and use "selected" or "change". IMO, a "click" is a low-level interaction. Heavier renderers can certainly dispatch such a thing, but the "click" may not always mean that something was selected. Think of dividers in a menu or an unselectable item in a list, for example. It is up to the controller to determine the higher level meaning of that click. Also, if someone is using keyboard access, the item won't actually be clicked and the lower-level events of keyDown keyUp again are used by the controller to determine whether something is selected. So there should be an event with a higher level semantic meaning that the selection changed. Does List already have one that we can re-use? My 2 cents, -Alex