Hi Alex, I change the event from "valueChange" to "change" and as we use a standard flexjs Event it doesn't package any value. I added a "input" Event as well that makes the slider updates as we move the thumb.
Right now the example is working as MDL users expect, and I think will be fine with FlexJS users Maybe bundle the old value and new value would be a flexjs feature that will be appreciated by our users.... 2016-12-30 17:01 GMT+01:00 Alex Harui <aha...@adobe.com>: > > > On 12/30/16, 1:38 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" > <carlos.rov...@gmail.com on behalf of carlos.rov...@codeoscopic.com> > wrote: > > > >I really does not talk to introduce new events, in Slider, I must to get > >the slider change event that the MDL control is dispatching and then make > >our slider flexjs component throw a "valueChange" flexjs event. I think > >most of the time we will do this since is how MDL framework controls > >works. > >My question was more about, if we should call "valueChange" event as is or > >call it only "change" like MDL does. I think we both likes flexjs name > >"valueChange" > > I would prefer "change". It seems to be a common expectation. Lots of > controls dispatch it. FWIW, "valueChange" is being used for properties > with [Bindable] that don't specify their own event name (in regular Flex > it was called "propertyChange" but not everything that changes is a > property). > > Another thing to think about is whether you need to package up all of the > things in a ValueChangeEvent like the property name, old value, and new > value. The data binding code definitely needs property name to > distinguish one bindable property change from another, but I think most > control users don't need it and can just easily look at the current value > of the control. Then the code doesn't have to waste time packaging up > that extra data. > > Of course, other opinions are welcome... > -Alex > > -- Carlos Rovira Director General M: +34 607 22 60 05 http://www.codeoscopic.com http://www.avant2.es Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o confidencial. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la prestación del servicio o información solicitados, teniendo usted derecho de acceso, rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación necesaria.
