On 1/2/17, 3:38 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" <carlos.rov...@gmail.com on behalf of carlos.rov...@codeoscopic.com> wrote:
>I opened a branch in falcon and asjs for this ticket, but I think I'm a >bit >stuck with that...don't know how to continue... Well, I assume "mvn clean install" builds both repos for you. In compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/mxml/fl exjs/TestFlexJSMXMLApplication.java There is a test called testCSSComplexSelectors. It compiles the files in compiler-jx/src/test/resources/flexjs/files/CSSTest.mxml Which has a css file: compiler-jx/src/test/resources/flexjs/files/CSSTestSource.css Which should be output as: compiler-jx/src/test/resources/flexjs/files/CSSTestSource_result.css I would add the calc() function to CSSTestSource.css and what you expect to CSSTestSource_result.css and run the test via Junit. You should get an error or bad output. If you are trying to compare the expected vs actual you can use this app to help you compare the results: http://home.apache.org/~aharui/TestResultCompare/TestResultCompare.html The file you should need to change are in my earlier reply below. Hope that's what you needed to know. -Alex > >2017-01-01 10:36 GMT+01:00 OmPrakash Muppirala <bigosma...@gmail.com>: > >> JIRA created here: https://issues.apache.org/jira/browse/FLEX-35235 >> >> Thanks, >> Om >> >> On Fri, Dec 30, 2016 at 10:34 AM, Alex Harui <aha...@adobe.com> wrote: >> >> > >> > >> > On 12/30/16, 8:30 AM, "carlos.rov...@gmail.com on behalf of Carlos >> Rovira" >> > <carlos.rov...@gmail.com on behalf of carlos.rov...@codeoscopic.com> >> > wrote: >> > >> > >Hi Alex, a brief summary in this email of where we should look, >>classes >> > >involved and some explanations of what should we find would be a >>great >> > >place to start. thanks! >> > >> > It looks like calc() is a function. It looks like the compiler >>already >> > handles some functions like ClassReference() and local(), so I think >>the >> > trick is to copy how ClassReference is used in the lexer and parser. >>The >> > lexer is: >> > >> > compiler/src/main/antlr3/org/apache/flex/compiler/internal/css/CSS.g >> > >> > The parser is: >> > >>compiler/src/main/antlr3/org/apache/flex/compiler/internal/css/CSSTree.g >> > >> > >> > The parser creates instances of classes that represent the CSS. A new >> > class definition for calc() is probably needed. >> > >> > Then in >> > compiler-jx/src/main/java/org/apache/flex/compiler/internal/ >> > driver/js/flexj >> > s/JSCSSCompilationSession.java >> > The emitCSS method re-generates the CSS file from the data structure. >> > >> > Thanks, >> > -Alex >> > >> > >> > > > >-- > >Carlos Rovira >Director General >M: +34 607 22 60 05 >http://www.codeoscopic.com >http://www.avant2.es > >Este mensaje se dirige exclusivamente a su destinatario y puede contener >información privilegiada o confidencial. Si ha recibido este mensaje por >error, le rogamos que nos lo comunique inmediatamente por esta misma vía y >proceda a su destrucción. > >De la vigente Ley Orgánica de Protección de Datos (15/1999), le >comunicamos >que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC >S.A. La finalidad de dicho tratamiento es facilitar la prestación del >servicio o información solicitados, teniendo usted derecho de acceso, >rectificación, cancelación y oposición de sus datos dirigiéndose a >nuestras >oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación >necesaria.