On Jan 15, 2017 9:28 AM, "Carlos Rovira" <[email protected]> wrote:
@Alex, I only use what you propose : typeNames and className, so I think we are in sync. The problem is how to do the maintenance, since we are dealing with classproperties, I think the chosen path (of insert that line per property setter) is the right way to do, since is only one line of code...we as well could make a UIBase method with that line (the common class for all components) if we want to change that some day I prefer we create a ComponentUIBase based on UIBase and add this logic here. And make all components extend ComponentUIBase instead of UIBase. @Om, as we are developing a framework, I don't like the idea of an additional div. Is like the need in basic component set of having in all components "style='position:relative'. In that case seems Alex didn't find any better solution. I think if we make some research we could find it. In MDL all HTML generated code is the simpler code that MDL samples output and the docs dictate Think in this case as what it is. These are class properties that its way to function is add or remove class selector from the component, so for me if the property is a Boolean (for example), the is true, it adds the class selector, and for me that means that we need to add to internal typeName list, and when false, we must remove it, so users operations don't affect the basic workflow. Makes sense. While looking at this I notice that mxml property assignment order is important in class selector assignaments, and this should not be the case. If I put the className assignment first and then a property assignment, that cloack the problem, when doing in reverse order, it was showing the problem. With the proposed fix now you can use whatever order you want. This remember me something similar to when in commitProperties() we use to call invalidateProperties(). Maybe we should create a "invalidateClassSelectors()" or better... "updateTypeNames()" with that line Yes, we should use the requestAnimationFrame method and do all the reads and writes in one go. That would improve rendering performance as well. What do you think? 2017-01-15 10:08 GMT+01:00 piotrz <[email protected]>: > Carlos, Alex, Om, > > Maybe this issue should be resolved as Alex said, but in a higher level. In > some UIBase by having this internal list. If I understand correct it will > be > list which merges both things? > > Adding aditional could mess up some components - I think Tab, but not sure. > > Piotr > > > > > > ----- > Apache Flex PMC > [email protected] > -- > View this message in context: http://apache-flex- > development.2333347.n4.nabble.com/FlexJS-className-problem- > with-MDL-properties-that-modifies-component-className-tp58284p58311.html > Sent from the Apache Flex Development mailing list archive at Nabble.com. > -- Carlos Rovira Director General M: +34 607 22 60 05 http://www.codeoscopic.com http://www.avant2.es Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o confidencial. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la prestación del servicio o información solicitados, teniendo usted derecho de acceso, rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación necesaria.
